Skip to contentSkip to conversation

abituguru: Fix fan detection

PATCH New Jean Delvare 1 participant 1 message Jun 4, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 11/11 abituguru: Fix fan detection

From: Hans de Goede <j.w.r.degoede at hhs.nl>
Content-Disposition: inline; filename=hwmon-abituguru-nofans-detect-fix.patch

One of my testers had a problem where the driver only saw 2 of the 4 fan sensors his uGuru has, this fixes this.
-accept 0x40 (bit 6) being high as a valid fan sensor setting for all fans
not just fan 1, I have a feeling this bit indicates whether or not a fan is actually connected .

Signed-off-by Hans de Goede <j.w.r.degoede at hhs.nl>
Signed-off-by Jean Delvare <khali at linux-fr.org>
---
 drivers/hwmon/abituguru.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/hwmon/abituguru.c +2 -3
@@ -529,9 +529,8 @@
 		   -0x08 enable beep
 		   -0x01 enable alarm
 		   All other bits should be 0, but on some motherboards
-		   0x40 (bit 6) is also high, at least for fan1 */
-		if ((!i && (data->bank2_settings[i][0] & ~0xC9)) ||
-		     (i && (data->bank2_settings[i][0] & ~0x89))) {
+		   0x40 (bit 6) is also high for some of the fans?? */
+		if (data->bank2_settings[i][0] & ~0xC9) {
 			ABIT_UGURU_DEBUG(2, "  bank2 sensor %d does not seem "
 				"to be a fan sensor: settings[0] = %02X\n",
 				i, (unsigned int)data->bank2_settings[i][0]);
Signature · 1 line
Jean Delvare