Skip to contentSkip to conversation

Get rid of /proc/sys/proc

PATCH New Stephen Hemminger 2 participants 4 messages Jun 7, 2006 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Get rid of /proc/sys/proc

The table is empty, why does it still exist?

kernel/sysctl.c +0 -11
@@ -142,7 +142,6 @@
 
 static ctl_table kern_table[];
 static ctl_table vm_table[];
-static ctl_table proc_table[];
 static ctl_table fs_table[];
 static ctl_table debug_table[];
 static ctl_table dev_table[];
@@ -202,12 +201,6 @@
 	},
 #endif
 	{
-		.ctl_name	= CTL_PROC,
-		.procname	= "proc",
-		.mode		= 0555,
-		.child		= proc_table,
-	},
-	{
 		.ctl_name	= CTL_FS,
 		.procname	= "fs",
 		.mode		= 0555,
@@ -918,10 +911,6 @@
 	{ .ctl_name = 0 }
 };
 
-static ctl_table proc_table[] = {
-	{ .ctl_name = 0 }
-};
-
 static ctl_table fs_table[] = {
 	{
 		.ctl_name	= FS_NRINODE,
include/linux/sysctl.h +1 -3
@@ -55,7 +55,7 @@
 	CTL_KERN=1,		/* General kernel info and control */
 	CTL_VM=2,		/* VM management */
 	CTL_NET=3,		/* Networking */
-	CTL_PROC=4,		/* Process info */
+	/* was CTL_PROC */
 	CTL_FS=5,		/* Filesystems */
 	CTL_DEBUG=6,		/* Debugging */
 	CTL_DEV=7,		/* Devices */
@@ -762,8 +762,6 @@
 	NET_BRIDGE_NF_FILTER_VLAN_TAGGED = 4,
 };
 
-/* CTL_PROC names: */
-
 /* CTL_FS names: */
 enum
 {
#1 lore raw

PATCH 1/1 Get rid of /proc/sys/debug

Another empty table with no entries.

include/linux/sysctl.h +1 -3
@@ -57,7 +57,7 @@
 	CTL_NET=3,		/* Networking */
 	/* was CTL_PROC */
 	CTL_FS=5,		/* Filesystems */
-	CTL_DEBUG=6,		/* Debugging */
+	/* was CTL_DEBUG */
 	CTL_DEV=7,		/* Devices */
 	CTL_BUS=8,		/* Busses */
 	CTL_ABI=9,		/* Binary emulation */
@@ -800,8 +800,6 @@
 	FS_DQ_WARNINGS = 9,
 };
 
-/* CTL_DEBUG names: */
-
 /* CTL_DEV names: */
 enum {
 	DEV_CDROM=1,
kernel/sysctl.c +0 -11
@@ -143,7 +143,6 @@
 static ctl_table kern_table[];
 static ctl_table vm_table[];
 static ctl_table fs_table[];
-static ctl_table debug_table[];
 static ctl_table dev_table[];
 extern ctl_table random_table[];
 #ifdef CONFIG_UNIX98_PTYS
@@ -207,12 +206,6 @@
 		.child		= fs_table,
 	},
 	{
-		.ctl_name	= CTL_DEBUG,
-		.procname	= "debug",
-		.mode		= 0555,
-		.child		= debug_table,
-	},
-	{
 		.ctl_name	= CTL_DEV,
 		.procname	= "dev",
 		.mode		= 0555,
@@ -1037,10 +1030,6 @@
 	{ .ctl_name = 0 }
 };
 
-static ctl_table debug_table[] = {
-	{ .ctl_name = 0 }
-};
-
 static ctl_table dev_table[] = {
 	{ .ctl_name = 0 }
 };
#2 lore raw

Re: [PATCH] Get rid of /proc/sys/debug

Quoted 1 line · On Wed, 7 Jun 2006 14:22:32 -0700 Stephen Hemminger wrote:

Another empty table with no entries.

Did you check on x86_64? I see this:

rddunlap@midway:/var/linsrc/linux-2617-rc6> ll /proc/sys/debug -rw-r--r-- 1 root root 0 2006-06-07 14:44 exception-trace

from arch/x86_64/mm/init.c

Quoted 45 lines
include/linux/sysctl.h +1 -3
@@ -57,7 +57,7 @@
 	CTL_NET=3,		/* Networking */
 	/* was CTL_PROC */
 	CTL_FS=5,		/* Filesystems */
-	CTL_DEBUG=6,		/* Debugging */
+	/* was CTL_DEBUG */
 	CTL_DEV=7,		/* Devices */
 	CTL_BUS=8,		/* Busses */
 	CTL_ABI=9,		/* Binary emulation */
@@ -800,8 +800,6 @@
 	FS_DQ_WARNINGS = 9,
 };
 
-/* CTL_DEBUG names: */
-
 /* CTL_DEV names: */
 enum {
 	DEV_CDROM=1,
kernel/sysctl.c +0 -7
@@ -143,7 +143,6 @@
 static ctl_table kern_table[];
 static ctl_table vm_table[];
 static ctl_table fs_table[];
-static ctl_table debug_table[];
 static ctl_table dev_table[];
 extern ctl_table random_table[];
 #ifdef CONFIG_UNIX98_PTYS
@@ -207,12 +206,6 @@
 		.child		= fs_table,
 	},
 	{
-		.ctl_name	= CTL_DEBUG,
-		.procname	= "debug",
-		.mode		= 0555,
-		.child		= debug_table,
-	},
-	{
 		.ctl_name	= CTL_DEV,
 		.procname	= "dev",
 		.mode		= 0555,

kernel/sysctl.c line 1035

Quoted 10 lines
kernel/sysctl.c +0 -4
@@ -1037,10 +1030,6 @@
 	{ .ctl_name = 0 }
 };
 
-static ctl_table debug_table[] = {
-	{ .ctl_name = 0 }
-};
-
 static ctl_table dev_table[] = {
 	{ .ctl_name = 0 }
 };

---
~Randy

#3 lore raw

Re: [PATCH] Get rid of /proc/sys/debug

Quoted 10 lines · On Wed, 7 Jun 2006 14:45:12 -0700 "Randy.Dunlap" <[email protected]> wrote:
Quoted 1 line · On Wed, 7 Jun 2006 14:22:32 -0700 Stephen Hemminger wrote:

Another empty table with no entries.

Did you check on x86_64? I see this:

rddunlap@midway:/var/linsrc/linux-2617-rc6> ll /proc/sys/debug -rw-r--r-- 1 root root 0 2006-06-07 14:44 exception-trace

from arch/x86_64/mm/init.c

It looks like if we left the CTL_DEBUG enum, then the x86_64 code would still work because it registers starting at /proc/sys so the debug directory would then be created only if needed.