check for error return from fork()
PATCH 1/1 check for error return from fork()
Trivial fixup for fork() callsites which do not check for errors.
Signed-off-by Paul T Darga <[email protected]>
--- connect.c | 2 ++ imap-send.c | 6 +++++- rsh.c | 6 +++++- 3 files changed, 12 insertions(+), 2 deletions(-)
connect.c +2 -0
@@ -657,6 +657,8 @@ int git_connect(int fd[2], char *url, coif (pipe (pipefd[0 ]) <0 ||pipe (pipefd[1 ]) <0 )die ("unable to create pipe pair for communication" ); pid =fork (); +if (pid <0 ) +die ("unable to fork" );if (!pid) {snprintf (command,sizeof (command),"%s %s" , prog,sq_quote (path));
imap-send.c +5 -1
@@ -924,6 +924,7 @@ imap_open_store( imap_server_conf_t *srvstruct hostent *he;struct sockaddr_in addr;int s, a[2 ], preauth; +pid_t pid; ctx =xcalloc (sizeof (*ctx),1 );
@@ -941,7 +942,10 @@ imap_open_store( imap_server_conf_t *srvexit (1 ); } -if (fork () ==0 ) { + pid =fork (); +if (pid <0 ) +_exit (127 ); +if (!pid) {if (dup2 ( a[0 ],0 ) ==-1 ||dup2 ( a[0 ],1 ) ==-1 )_exit (127 );close ( a[0 ] );
rsh.c +5 -1
@@ -48,6 +48,7 @@ int setup_connection(int *fd_in, int *fdint sizen;int of;int i; +pid_t pid;if (!strcmp (url,"-" )) { *fd_in =0 ;
@@ -91,7 +92,10 @@ int setup_connection(int *fd_in, int *fdif (socketpair (AF_UNIX ,SOCK_STREAM ,0 , sv))return error ("Couldn't create socket" ); -if (!fork ()) { + pid =fork (); +if (pid <0 ) +return error ("Couldn't fork" ); +if (!pid) {const char *ssh, *ssh_basename; ssh =getenv ("GIT_SSH" );if (!ssh) ssh ="ssh" ;
Signature · 8 lines
1.4.0.rc2 -- Paul T. Darga - [email protected] - http://www.eecs.umich.edu/~pdarga/ "When I gave food to the poor, they called me a saint. When I asked why the poor were hungry, they called me a communist." -- Dom Helder Camara, Brazilian Bishop, Nobel Peace Prize nominee