Skip to contentSkip to conversation

powerpc: console_initcall ordering issues

PATCH In review Anton Blanchard 2 participants 2 messages Jun 10, 2006 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: console_initcall ordering issues

From: Milton Miller <[email protected]>

The add_preferred_console call in rtas_console.c was not causing the console to be selected. It turns out that the add_preferred_console was being called after the hvc_console driver was registered. It only works when it is called before the console driver is registered.

Reorder hvc_console.o after the hvc_console drivers to allow the selection during console_initcall processing.

---

drivers/char/Makefile +1 -1
Index: kernel/drivers/char/Makefile
===================================================================
@@ -41,9 +41,9 @@ obj-$(CONFIG_N_HDLC)		+= n_hdlc.o
 obj-$(CONFIG_AMIGA_BUILTIN_SERIAL) += amiserial.o
 obj-$(CONFIG_SX)		+= sx.o generic_serial.o
 obj-$(CONFIG_RIO)		+= rio/ generic_serial.o
-obj-$(CONFIG_HVC_DRIVER)	+= hvc_console.o
 obj-$(CONFIG_HVC_CONSOLE)	+= hvc_vio.o hvsi.o
 obj-$(CONFIG_HVC_RTAS)		+= hvc_rtas.o
+obj-$(CONFIG_HVC_DRIVER)	+= hvc_console.o
 obj-$(CONFIG_RAW_DRIVER)	+= raw.o
 obj-$(CONFIG_SGI_SNSC)		+= snsc.o snsc_event.o
 obj-$(CONFIG_MMTIMER)		+= mmtimer.o
maintainer
#1 lore raw

Am Saturday 10 June 2006 14:16 schrieb Anton Blanchard:

Quoted 4 lines

The add_preferred_console call in rtas_console.c was not causing the console to be selected. It turns out that the add_preferred_console was being called after the hvc_console driver was registered. It only works when it is called before the console driver is registered.

Great, thanks for nailing this one down. We've had multiple people trying without success to figure out why it couldn't automatically find the console.

	Arnd <><