Skip to contentSkip to conversation

genirq error message clarification

PATCH-rt Deepak Saxena 2 participants 2 messages Jun 10, 2006 IRQ

lore
Share & tools
lore
#0 lore raw

It makes it a bit easier to debug issues when we know what irq we're having problems with.

kernel/irq/manage.c +2 -1
Index: linux-2.6-rt/kernel/irq/manage.c
===================================================================
@@ -328,7 +328,8 @@ int setup_irq(unsigned int irq, struct i
 mismatch:
 	spin_unlock_irqrestore(&desc->lock, flags);
 	if (!(new->flags & SA_PROBEIRQ)) {
-		printk(KERN_ERR "%s: irq handler mismatch\n", __FUNCTION__);
+		printk(KERN_ERR "%s: irq %d handler mismatch\n", __FUNCTION__,
+				irq);
 		dump_stack();
 	}
 	return -EBUSY;
Signature · 4 lines
Deepak Saxena - [email protected] - http://www.plexity.net

In the end, they will not say, "those were dark times,"  they will ask
"why were their poets silent?" - Bertold Brecht
#1 lore raw
Quoted 11 lines · Deepak Saxena

It makes it a bit easier to debug issues when we know what irq we're having problems with.

Index: linux-2.6-rt/kernel/irq/manage.c
===================================================================

kernel/irq/manage.c int setup_irq(unsigned int irq, struct i · line 335

Quoted 9 lines
kernel/irq/manage.c +2 -1
@@ -328,7 +328,8 @@ int setup_irq(unsigned int irq, struct i
 mismatch:
 	spin_unlock_irqrestore(&desc->lock, flags);
 	if (!(new->flags & SA_PROBEIRQ)) {
-		printk(KERN_ERR "%s: irq handler mismatch\n", __FUNCTION__);
+		printk(KERN_ERR "%s: irq %d handler mismatch\n", __FUNCTION__,
+				irq);
 		dump_stack();
 	}
 	return -EBUSY;

Makes sense. Thanks, applied

tglx