Skip to contentSkip to conversation

s390: incomplete stack traces.

PATCH New Martin Schwidefsky 1 participant 1 message Jun 14, 2006 s390

lore
Share & tools
lore
#0 lore raw

PATCH 2/24 s390: incomplete stack traces.

From: Heiko Carstens <[email protected]>

[S390] incomplete stack traces.

show_stack() passes a pointer to the current stack frame to show_trace(). Because of tail call optimization the pointer doesn't point to the original stack frame anymory and therefore traces are wrong. Don't pass the pointer of the current stack frame to show_trace(). Instead let show_trace() calculate the pointer on its own.

---

 arch/s390/kernel/traps.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
arch/s390/kernel/traps.c +3 -5
diff -urpN linux-2.6/arch/s390/kernel/traps.c linux-2.6-patched/arch/s390/kernel/traps.c
@@ -150,13 +150,11 @@ void show_stack(struct task_struct *task
 	unsigned long *stack;
 	int i;
 
-	// debugging aid: "show_stack(NULL);" prints the
-	// back trace for this cpu.
-
 	if (!sp)
-		sp = task ? (unsigned long *) task->thread.ksp : __r15;
+		stack = task ? (unsigned long *) task->thread.ksp : __r15;
+	else
+		stack = sp;
 
-	stack = sp;
 	for (i = 0; i < kstack_depth_to_print; i++) {
 		if (((addr_t) stack & (THREAD_SIZE-1)) == 0)
 			break;