s390: ccwgroup device unregister.
Subsystems (2)
PATCH 6/24 s390: ccwgroup device unregister.
From: Cornelia Huck <[email protected]>
[S390] ccwgroup device unregister.
Work around the problem that a device cannot be unregistered from driver_for_each_device() because of klist node refcounting: Get device after device owned by the driver to be unregistered with driver_find_device() and then unregister it. This works because driver_get_device() gets us out of the region of the elevated klist node refcount. driver_find_device() will always get the next device in the list after the found one has been unregistered.
Signed-off-by Cornelia Huck <[email protected]>
Signed-off-by Martin Schwidefsky <[email protected]>
---
drivers/s390/cio/ccwgroup.c | 17 ++++++++++------- 1 files changed, 10 insertions(+), 7 deletions(-)
drivers/s390/cio/ccwgroup.c +10 -7
@@ -404,21 +404,24 @@ ccwgroup_driver_register (struct ccwgrou }static int -__ccwgroup_driver_unregister_device (struct device *dev,void *data) +__ccwgroup_match_all (struct device *dev,void *data) { -__ccwgroup_remove_symlinks (to_ccwgroupdev (dev)); -device_unregister (dev); -put_device (dev); -return 0 ; +return 1 ; }void ccwgroup_driver_unregister (struct ccwgroup_driver *cdriver) { +struct device *dev; +/* We don't want ccwgroup devices to live longer than their driver. */ get_driver (&cdriver->driver); -driver_for_each_device (&cdriver->driver,NULL ,NULL , - __ccwgroup_driver_unregister_device); +while ((dev =driver_find_device (&cdriver->driver,NULL ,NULL , + __ccwgroup_match_all))) { +__ccwgroup_remove_symlinks (to_ccwgroupdev (dev)); +device_unregister (dev); +put_device (dev); + }put_driver (&cdriver->driver);driver_unregister (&cdriver->driver); }