PATCH: Quieten sparse on lpfc driver
Subsystems (2)
No actual bugs I can see just labelling needed and 0/NULL fixes
Signed-off-by Alan Cox <[email protected]>
drivers/scsi/lpfc/lpfc_els.c +3 -3
@@ -821,7 +821,7 @@ pring = &psli->ring[LPFC_ELS_RING ];/* ELS ring */ cmdsize = (sizeof (uint32_t ) +sizeof (struct serv_parm )); - elsiocb =lpfc_prep_els_iocb (phba,1 , cmdsize, retry,0 , did, + elsiocb =lpfc_prep_els_iocb (phba,1 , cmdsize, retry,NULL , did,ELS_CMD_PLOGI );if (!elsiocb)return 1 ;
@@ -2791,8 +2791,8 @@ ndlp = (struct lpfc_nodelist *) pmb->context2; xri = (uint16_t ) ((unsigned long )(pmb->context1)); - pmb->context1 =0 ; - pmb->context2 =0 ; + pmb->context1 =NULL ; + pmb->context2 =NULL ;if (mb->mbxStatus) {mempool_free ( pmb, phba->mbox_mem_pool);
drivers/scsi/lpfc/lpfc_init.c +2 -2
@@ -939,12 +939,12 @@ "10-port ", "PCIe"};break ;default : - m = (typeof (m )){0 }; + m = (typeof (m )){NULL };break ; }break ;default : - m = (typeof (m )){0 }; + m = (typeof (m )){NULL };break ; }
drivers/scsi/lpfc/lpfc_sli.c +5 -5
@@ -1570,8 +1570,8 @@void lpfc_reset_barrier (struct lpfc_hba * phba) { -uint32_t * resp_buf; -uint32_t * mbox_buf; +uint32_t __iomem *resp_buf; +uint32_t __iomem *mbox_buf;volatile uint32_t mbox;uint32_t hc_copy;int i;
@@ -1587,7 +1587,7 @@* Tell the other part of the chip to suspend temporarily all * its DMA activity. */ - resp_buf = (uint32_t *)phba->MBslimaddr; + resp_buf = (uint32_t __iomem *)phba->MBslimaddr;/* Disable the error attention */ hc_copy =readl (phba->HCregaddr);
@@ -1605,7 +1605,7 @@ ((MAILBOX_t *)&mbox)->mbxOwner =OWN_CHIP ;writel (BARRIER_TEST_PATTERN , (resp_buf +1 )); - mbox_buf = (uint32_t *)phba->MBslimaddr; + mbox_buf = (uint32_t __iomem *)phba->MBslimaddr;writel (mbox, mbox_buf); for (i = 0;
@@ -1805,7 +1805,7 @@ skip_post =0 ; word0 =0 ;/* This is really setting up word1 */ } - to_slim = (uint8_t *) phba->MBslimaddr +sizeof (uint32_t ); + to_slim = (uint8_t __iomem *) phba->MBslimaddr +sizeof (uint32_t );writel (*(uint32_t *) mb, to_slim);readl (to_slim);/* flush */
Quoted 1 line · Alan Cox
No actual bugs I can see just labelling needed and 0/NULL fixes
ACK, but I thought we are too late for that in this cycle...
Al, sitting on ~200 patches of such kind, including
commit aed9ad56701ffb209b7e2f4e52612739b7460fc8
Author: Al Viro <[email protected]> Date: Sun May 28 14:57:07 2006 -0400
[PATCH] scsi/lpfc __iomem annotations, NULL noise removal
Quoted 1 line · Al Viro
Al, sitting on ~200 patches of such kind, including
Well .. scsi-misc is collecting for the next cycle. Additionally the patches that affect maintained drivers, like lpfc, need to go through the maintainers of those drivers, so now would be a good time to begin preparing this for that cycle.
James