Skip to contentSkip to conversation

I2C: fix 'ignore' module parameter

PATCH New Mark M. Hoffman 2 participants 2 messages Jun 17, 2006 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C: fix 'ignore' module parameter

This patch fixes a bug in the handling of 'ignore' module parameters of I2C client drivers.

Signed-off-by Mark M. Hoffman <mhoffman at lightlink.com>
drivers/i2c/i2c-core.c +2 -2
@@ -756,9 +756,9 @@ int i2c_probe(struct i2c_adapter *adapte
 					"parameter for adapter %d, "
 					"addr 0x%02x\n", adap_id,
 					address_data->ignore[j + 1]);
+				ignore = 1;
+				break;
 			}
-			ignore = 1;
-			break;
 		}
 		if (ignore)
 			continue;
Signature · 2 lines
Mark M. Hoffman
mhoffman at lightlink.com
#1 lore raw

PATCH 1/1 I2C: fix 'ignore' module

Hi Mark,

Quoted 10 lines

This patch fixes a bug in the handling of 'ignore' module parameters of I2C client drivers.

Signed-off-by Mark M. Hoffman <mhoffman at lightlink.com>
drivers/i2c/i2c-core.c +0 -0
@@ -756,9 +756,9 @@ int i2c_probe(struct i2c_adapter *adapte
 					"parameter for adapter %d, "

drivers/i2c/i2c-core.c int i2c_probe(struct i2c_adapter *adapte · line 764

Quoted 10 lines
drivers/i2c/i2c-core.c +2 -2
 					"addr 0x%02x\n", adap_id,
 					address_data->ignore[j + 1]);
+				ignore = 1;
+				break;
 			}
-			ignore = 1;
-			break;
 		}
 		if (ignore)
 			continue;

Oops, it seems I screwed up when rewriting i2c_probe 10 months ago. Thanks a lot for catching this, I've applied your patch.

Signature · 1 line
Jean Delvare