Skip to contentSkip to conversation

x86: add NUMA to oops messages

PATCH Chuck Ebbert 4 participants 4 messages Jun 18, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 5 lines · Andi Kleen
Quoted 2 lines · Chuck Ebbert

Add "NUMA" to x86 oops printouts to help with debugging. Use vermagic.h defines to clean up the code, suggested by Arjan van de Ven.

I don't see any particular value in printing NUMA here,

It helps a lot when trying to decode oopses posted to the list, as the NUMA kernel is very different now that the slab allocator and scheduler are NUMA-aware.

 $ fgrep 'def CONFIG_NUMA' mm/*.c kernel/*.c include/linux/* | wc -l
 58
 $ fgrep 'def CONFIG_SMP' mm/*.c kernel/*.c include/linux/* | wc -l
 81
Quoted 2 lines

and putting half of .config into the oops doesn't seem like a good long term strategy.

It's just this one thing; I can't think of anything else to add...

Signature · 2 lines
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush
#1 lore raw
Quoted 5 lines · Chuck Ebbert
Quoted 2 lines

and putting half of .config into the oops doesn't seem like a good long term strategy.

It's just this one thing; I can't think of anything else to add...

if it's compact I'd actually put the entire vermagic line there... it'll show compiler, preempt and a whole lot of other "distinctive" features

#2 lore raw
Quoted 9 lines · On Sun, 18 Jun 2006 14:48:27 +0200 Arjan van de Ven wrote:
Quoted 5 lines · Chuck Ebbert
Quoted 2 lines

and putting half of .config into the oops doesn't seem like a good long term strategy.

It's just this one thing; I can't think of anything else to add...

if it's compact I'd actually put the entire vermagic line there... it'll show compiler, preempt and a whole lot of other "distinctive" features

Yep, I like that idea too.

---
~Randy

#3 lore raw
In reply to Chuck Ebbert

Am So 18.06.2006 14:13 schrieb Chuck Ebbert <[email protected]>:

Quoted 9 lines

In-Reply-To: <[email protected]>

Quoted 5 lines · Andi Kleen
Quoted 3 lines · Chuck Ebbert

Add "NUMA" to x86 oops printouts to help with debugging. Use vermagic.h
defines to clean up the code, suggested by Arjan van de Ven.

Quoted 6 lines
Quoted 1 line

I don't see any particular value in printing NUMA here,

It helps a lot when trying to decode oopses posted to the list, as the NUMA kernel is very different now that the slab allocator and scheduler
are NUMA-aware.

And there are a thousand other things that change with other CONFIG_* options. I also can't remember a bug where this wasn't clear.

In general the rule of thumb is: i386: NUMA is not used and x86-64 SMP: NUMA is used.

-Andi