2.6.17: CONFIG_PARPORT_SERIAL should require CONFIG_SERIAL_8250_PCI?
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Just rebuilt 2.6.17 from older config and disabling 8250 PCI (I do not have any on notebook) and got:
WARNING: "pciserial_init_ports" [drivers/parport/parport_serial.ko] undefined!
WARNING: "pciserial_suspend_ports" [drivers/parport/parport_serial.ko] undefined!
WARNING: "pciserial_remove_ports" [drivers/parport/parport_serial.ko] undefined!
WARNING: "pciserial_resume_ports" [drivers/parport/parport_serial.ko] undefined!
# CONFIG_SERIAL_8250_PCI is not setCONFIG_PARPORT_SERIAL=m
PARPORT_SERIAL is probably leftover that I overlooked, I do not actually need this either.
- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
iD8DBQFElSmVR6LMutpd94wRAmDrAKCgKU5OIDhTqqPuyqNE8G1tHnzONACgq6+B hvNakgfw8FQV4nUSfga8/DQ=
=oD/G
-----END PGP SIGNATURE-----
Quoted 2 lines · Andrey Borzenkov
Just rebuilt 2.6.17 from older config and disabling 8250 PCI (I do not have any on notebook) and got:
Thanks for reporting this. The patch below should fix this - please test so it can be submitted for the stable branch, thanks.
# Base git commit: 427abfa28afedffadfca9dd8b067eb6d36bac53f
# (Linux v2.6.17)
#
# Author: Russell King (Sun Jun 18 13:00:48 BST 2006)
# Committer: Russell King (Sun Jun 18 13:00:48 BST 2006) #
# [SERIAL] PARPORT_SERIAL should depend on SERIAL_8250_PCI
#
# Since parport_serial uses symbols from 8250_pci, there should
# be a dependency between the configuration symbols for these
# two modules. Problem reported by Andrey Borzenkov
#
# Signed-off-by: Russell King
#
# drivers/parport/Kconfig | 2 +-
# 1 files changed, 1 insertions(+), 1 deletions(-)
#
drivers/parport/Kconfig +1 -1
@@ -48,7 +48,7 @@ config PARPORT_PC config PARPORT_SERIAL tristate "Multi-IO cards (parallel and serial)" - depends on SERIAL_8250 && PARPORT_PC && PCI + depends on SERIAL_8250_PCI && PARPORT_PC && PCI help This adds support for multi-IO PCI cards that have parallel and serial ports. You should say Y or M here. If you say M, the module
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 7 lines · Russell King
Quoted 2 lines · Andrey Borzenkov
Just rebuilt 2.6.17 from older config and disabling 8250 PCI (I do not have any on notebook) and got:
Thanks for reporting this. The patch below should fix this - please test so it can be submitted for the stable branch, thanks.
I confirm that with this patch doing oldconfig and deselecting SERIAL_8250_PCI also deselects PARPORT_SERIAL.
regards
- -andrey
Quoted 21 lines
# Base git commit:
427abfa28afedffadfca9dd8b067eb6d36bac53f
# (Linux v2.6.17)
#
# Author: Russell King (Sun Jun 18 13:00:48 BST 2006)
# Committer: Russell King (Sun Jun 18 13:00:48 BST 2006) #
# [SERIAL]PARPORT_SERIALshould depend onSERIAL_8250_PCI
#
# Sinceparport_serialuses symbols from 8250_pci, there should
# be a dependency between the configuration symbols for these
# two modules. Problem reported by Andrey Borzenkov
#
# Signed-off-by: Russell King
#
#drivers/parport/Kconfig| 2 +-
# 1 files changed, 1 insertions(+), 1 deletions(-)
#
drivers/parport/Kconfig config PARPORT_PC · line 54
Quoted 8 lines
drivers/parport/Kconfig +1
-1@@ -48,7 +48,7 @@ config PARPORT_PC config PARPORT_SERIAL tristate "Multi-IO cards (parallel and serial)" - depends on SERIAL_8250 && PARPORT_PC && PCI + depends on SERIAL_8250_PCI && PARPORT_PC && PCI help This adds support for multi-IO PCI cards that have parallel and serial ports. You should say Y or M here. If you say M, the module
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
iD8DBQFElXEzR6LMutpd94wRAh5PAKC7rNyFMqogQPGgYYixgK14M6hwcgCgs8h8 IqQIn2z447RBjQGLXM00iog=
=Tisv
-----END PGP SIGNATURE-----