Skip to contentSkip to conversation

connector: export cn_already_initialized.

PATCH Applied Evgeniy Polyakov 2 participants 7 messages May 4, 2006 – Jun 20, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 connector: export cn_already_initialized.

Some modules depend on that value, although it was initially introduced for in-kernel static build.

No in-kernel users require it to be exported, so if you do think it should not be exported I will force external module changes.

drivers/connector/connector.c +1 -0
@@ -486,3 +486,4 @@ module_exit(cn_fini);
 EXPORT_SYMBOL_GPL(cn_add_callback);
 EXPORT_SYMBOL_GPL(cn_del_callback);
 EXPORT_SYMBOL_GPL(cn_netlink_send);
+EXPORT_SYMBOL_GPL(cn_already_initialized);
Signature · 1 line
	Evgeniy Polyakov
maintainer
#1 lore raw

From: Evgeniy Polyakov <[email protected]>
Date: Thu, 4 May 2006 16:24:22 +0400

Quoted 2 lines

No in-kernel users require it to be exported, so if you do think it should not be exported I will force external module changes.

What are the alternatives?

#2 lore raw
Quoted 7 lines · David S. Miller

From: Evgeniy Polyakov <[email protected]>
Date: Thu, 4 May 2006 16:24:22 +0400

Quoted 2 lines

No in-kernel users require it to be exported, so if you do think it should not be exported I will force external module changes.

What are the alternatives?

This flag shows that connector has finished it's initialization and now it's calbacks can be safely added. In-kernel users (like various accountings) which are initialized first (like fs) use that flag to check if connector can be added or not.

Some external patches, which can be built both as static build and as module just check that value, and thus will fail with unresolved symbol when cn and module are built as modules.

The right set of operations should be following:
If external module is loaded and cn is not loaded or compiled into the kernel, insmod will just fail with unresolved symbol (cn_add_callback and others), if cn is already loaded or was built into the tree, then it has been initialized already and there is no need to check that value, external module should be just loaded.

I think the right solution is to call external init functions after cn init function, but it's ordering is not always known.

While writing this I've thought another solution, when cn_add_callback() will just return -EINPROGRESS or other special error, which means that it is too early to call it and it must be run later.

drivers/connector/connector.c +5 -2
index 3589707..f852e68 100644
@@ -308,6 +308,9 @@ int cn_add_callback(struct cb_id *id, ch
 	int err;
 	struct cn_dev *dev = &cdev;
 
+	if (!cn_already_initialized)
+		return -EINPROGRESS;
+
 	err = cn_queue_add_callback(dev->cbdev, name, id, callback);
 	if (err)
 		return err;
@@ -456,6 +459,8 @@ static int __init cn_init(void)
 			sock_release(dev->nls->sk_socket);
 		return -EINVAL;
 	}
+	
+	cn_already_initialized = 1;
 
 	err = cn_add_callback(&dev->id, "connector", &cn_callback);
 	if (err) {
@@ -465,8 +470,6 @@ static int __init cn_init(void)
 		return -EINVAL;
 	}
 
-	cn_already_initialized = 1;
-
 	return 0;
 }
 
Signature · 1 line
	Evgeniy Polyakov
maintainer
#3 lore raw

From: Evgeniy Polyakov <[email protected]>
Date: Sat, 6 May 2006 12:40:45 +0400

Quoted 11 lines

Some external patches, which can be built both as static build and as module just check that value, and thus will fail with unresolved symbol when cn and module are built as modules.

The right set of operations should be following:
If external module is loaded and cn is not loaded or compiled into the kernel, insmod will just fail with unresolved symbol (cn_add_callback and others), if cn is already loaded or was built into the tree, then it has been initialized already and there is no need to check that value, external module should be just loaded.

Quoted 2 lines

I think the right solution is to call external init functions after cn init function, but it's ordering is not always known.

In-kernel build of connector subsystem can be handled by making cn_init a "subsystem_init()", it will then be setup before any possible static or modular reference as long as those modules use module_init().

For modular case of connector, dependency of module on connector module should handle all ordering issues, making any ordering issue take care of itself.

#4 lore raw
Quoted 9 lines · David S. Miller

From: Evgeniy Polyakov <[email protected]>
Date: Sat, 6 May 2006 12:40:45 +0400

Quoted 2 lines

I think the right solution is to call external init functions after cn init function, but it's ordering is not always known.

In-kernel build of connector subsystem can be handled by making cn_init a "subsystem_init()", it will then be setup before any possible static or modular reference as long as those modules use module_init().

subsystem_init() seems to be kobject related initilizator. Maybe subsys_initcall()?

I will cook up a patch if it works.
Thank you.

Signature · 1 line
	Evgeniy Polyakov
#5 lore raw
In reply to David S. Miller
Quoted 17 lines · David S. Miller

From: Evgeniy Polyakov <[email protected]>
Date: Sat, 6 May 2006 12:40:45 +0400

Quoted 11 lines

Some external patches, which can be built both as static build and as module just check that value, and thus will fail with unresolved symbol when cn and module are built as modules.

The right set of operations should be following:
If external module is loaded and cn is not loaded or compiled into the kernel, insmod will just fail with unresolved symbol (cn_add_callback and others), if cn is already loaded or was built into the tree, then it has been initialized already and there is no need to check that value, external module should be just loaded.

Quoted 2 lines

I think the right solution is to call external init functions after cn init function, but it's ordering is not always known.

Quoted 8 lines

In-kernel build of connector subsystem can be handled by making cn_init a "subsystem_init()", it will then be setup before any possible static or modular reference as long as those modules use module_init().

For modular case of connector, dependency of module on connector module should handle all ordering issues, making any ordering issue take care of itself.

Attached patch declares connector init function as subsys_init() and returns -EAGAIN in case connector is not initialized yet.

drivers/connector/connector.c +9 -5
index 505677f..d1d964f 100644
@@ -306,6 +306,9 @@ int cn_add_callback(struct cb_id *id, ch
 	int err;
 	struct cn_dev *dev = &cdev;
 
+	if (!cn_already_initialized)
+		return -EAGAIN;
+
 	err = cn_queue_add_callback(dev->cbdev, name, id, callback);
 	if (err)
 		return err;
@@ -433,7 +436,7 @@ static void cn_callback(void *data)
 	up(&notify_lock);
 }
 
-static int __init cn_init(void)
+static int __devinit cn_init(void)
 {
 	struct cn_dev *dev = &cdev;
 	int err;
@@ -454,21 +458,22 @@ static int __init cn_init(void)
 			sock_release(dev->nls->sk_socket);
 		return -EINVAL;
 	}
+	
+	cn_already_initialized = 1;
 
 	err = cn_add_callback(&dev->id, "connector", &cn_callback);
 	if (err) {
+		cn_already_initialized = 0;
 		cn_queue_free_dev(dev->cbdev);
 		if (dev->nls->sk_socket)
 			sock_release(dev->nls->sk_socket);
 		return -EINVAL;
 	}
 
-	cn_already_initialized = 1;
-
 	return 0;
 }
 
-static void __exit cn_fini(void)
+static void __devexit cn_fini(void)
 {
 	struct cn_dev *dev = &cdev;
 
@@ -480,7 +485,7 @@ static void __exit cn_fini(void)
 		sock_release(dev->nls->sk_socket);
 }
 
-module_init(cn_init);
+subsys_initcall(cn_init);
 module_exit(cn_fini);
 
 EXPORT_SYMBOL_GPL(cn_add_callback);
Signature · 1 line
	Evgeniy Polyakov
maintainer Applied
#6 lore raw

From: Evgeniy Polyakov <[email protected]>
Date: Mon, 19 Jun 2006 09:30:35 +0400

Quoted 4 lines

Attached patch declares connector init function as subsys_init() and returns -EAGAIN in case connector is not initialized yet.

Applied, but I had to fixup something by hand:

drivers/connector/connector.c static void cn_callback(void *data) · line 439

Quoted 6 lines
drivers/connector/connector.c +1 -1
@@ -433,7 +436,7 @@ static void cn_callback(void *data)
 	up(&notify_lock);
 }
 
-static int __init cn_init(void)
+static int __devinit cn_init(void)

notify_lock is now a mutex.