mspec
PATCH 1/1 mspec
Hi,
Since today is the day of do_no_pfn, it is obviously also the time for mspec! Here we go :)
Cheers,
Jes
This patch implements the special memory driver (mspec) based on the do_no_pfn approach. The driver is currently used only on SN2 hardware with special fetchop support but could be beneficial on other architectures using the uncached mode.
----
drivers/char/Kconfig | 8 drivers/char/Makefile | 1 drivers/char/mspec.c | 422 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 431 insertions(+)
drivers/char/Kconfig +8 -0
@@ -422,6 +422,14 @@ If you have an SGI Altix with an attached SABrick say Y or M here, otherwise say N. +config MSPEC + tristate "Memory special operations driver" + depends on IA64 + help + If you have an ia64 and you want to enable memory special + operations support (formerly known as fetchop), say Y here, + otherwise say N. + source "drivers/serial/Kconfig" config UNIX98_PTYS
drivers/char/Makefile +1 -0
@@ -51,6 +51,7 @@ obj-$(CONFIG_VIOTAPE) += viotape.o obj-$(CONFIG_HVCS) += hvcs.o obj-$(CONFIG_SGI_MBCS) += mbcs.o +obj-$(CONFIG_MSPEC) += mspec.o obj-$(CONFIG_PRINTER) += lp.o obj-$(CONFIG_TIPAR) += tipar.o
drivers/char/mspec.c new file +422 -0
422 lines not on this page · raw message
Quoted 4 lines · On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:
Hi,
Since today is the day of
do_no_pfn, it is obviously also the time for mspec! Here we go :)
Just minor stuff:
drivers/char/mspec.c line 422
Quoted 4 lines
drivers/char/mspec.c new file +4
-0+MODULE_AUTHOR ("Silicon Graphics, Inc." ); +MODULE_DESCRIPTION ("Driver for SGI SN special memory operations" ); +MODULE_LICENSE ("GPL" ); +MODULE_INFO (supported,"external" );
What does that last line mean? what does "external" mean? There are no other source files in the 2.6.17 tree that say anything like that.
And of the 1800+ MODULE_AUTHOR() lines, SGI seems to be
dominant is using company instead of a person for AUTHOR.
Yes, there are a few others as well.module.h says:
/* Author, ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME <EMAIL>] */
---
~Randy
Quoted 10 lines · Randy.Dunlap
drivers/char/mspec.c line 422
Quoted 4 lines · On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:
drivers/char/mspec.c new file +4
-0+MODULE_AUTHOR ("Silicon Graphics, Inc." ); +MODULE_DESCRIPTION ("Driver for SGI SN special memory operations" ); +MODULE_LICENSE ("GPL" ); +MODULE_INFO (supported,"external" );What does that last line mean? what does "external" mean? There are no other source files in the 2.6.17 tree that say anything like that.
Hi Randy,
I actually don't know where that comes from, we can just say supported.
Quoted 3 lines
And of the 1800+
MODULE_AUTHOR()lines, SGI seems to be dominant is using company instead of a person for AUTHOR. Yes, there are a few others as well.
I inherited the code from someone else who probably inherited it parts of it from somewhere else. However the point is that SGI as a company is willing to take responsibility for the code.
Cheers,
Jes
Quoted 4 lines · Jes Sorensen
Quoted 3 lines · Randy.Dunlap
Quoted 1 line · On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:
+MODULE_INFO(supported, "external");
That is a SuSE thing that keeps the tainted flag from being set.
Thanks,
Robin
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Randy" == Randy Dunlap <[email protected]> writes:
Quoted 3 lines · Randy> On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:
Review
Quoted 3 lines
(quoted diff) +3
-0+MODULE_AUTHOR("Silicon Graphics, Inc."); +MODULE_DESCRIPTION("Driver for SGI SN special memory operations"); +MODULE_LICENSE("GPL"); +MODULE_INFO(supported, "external");
Randy> What does that last line mean? what does "external" mean? Randy> There are no other source files in the 2.6.17 tree that say Randy> anything like that.
Randy> And of the 1800+ MODULE_AUTHOR() lines, SGI seems to be Randy> dominant is using company instead of a person for AUTHOR. Yes, Randy> there are a few others as well. module.h says: /* Author, Randy> ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME Randy> <EMAIL>] */
Randy,
I went back and looked through the usages of these macros and it does indeed seem that nobody else tries to state 'supported' in MODULE_INFO so I have removed that and added an email address to the author line, which should always stay valid.
Cheers,
Jes
This patch implements the special memory driver (mspec) based on the do_no_pfn approach. The driver is currently used only on SN2 hardware with special fetchop support but could be beneficial on other architectures using the uncached mode.
----
drivers/char/Kconfig | 8 drivers/char/Makefile | 1 drivers/char/mspec.c | 421 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 430 insertions(+)
drivers/char/Kconfig +8 -0
@@ -422,6 +422,14 @@ config SGI_MBCS If you have an SGI Altix with an attached SABrick say Y or M here, otherwise say N. +config MSPEC + tristate "Memory special operations driver" + depends on IA64 + help + If you have an ia64 and you want to enable memory special + operations support (formerly known as fetchop), say Y here, + otherwise say N. + source "drivers/serial/Kconfig" config UNIX98_PTYS
drivers/char/Makefile +1 -0
@@ -51,6 +51,7 @@ obj-$(CONFIG_VIOCONS) += viocons.o obj-$(CONFIG_VIOTAPE) += viotape.o obj-$(CONFIG_HVCS) += hvcs.o obj-$(CONFIG_SGI_MBCS) += mbcs.o +obj-$(CONFIG_MSPEC) += mspec.o obj-$(CONFIG_PRINTER) += lp.o obj-$(CONFIG_TIPAR) += tipar.o
drivers/char/mspec.c new file +421 -0
421 lines not on this page · raw message
Quoted 17 lines · On 20 Jun 2006 06:23:16 -0400 Jes Sorensen wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Randy" == Randy Dunlap <[email protected]> writes:
Quoted 3 lines · Randy> On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:
Review
Quoted 3 lines
(quoted diff) +3
-0+MODULE_AUTHOR("Silicon Graphics, Inc."); +MODULE_DESCRIPTION("Driver for SGI SN special memory operations"); +MODULE_LICENSE("GPL"); +MODULE_INFO(supported, "external");Randy> What does that last line mean? what does "external" mean? Randy> There are no other source files in the 2.6.17 tree that say Randy> anything like that.
Randy> And of the 1800+
MODULE_AUTHOR()lines, SGI seems to be Randy> dominant is using company instead of a person for AUTHOR. Yes, Randy> there are a few others as well.module.hsays: /* Author, Randy> ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME Randy> <EMAIL>] */
Quoted 6 lines
Randy,
I went back and looked through the usages of these macros and it does indeed seem that nobody else tries to state 'supported' in
MODULE_INFOso I have removed that and added an email address to the author line, which should always stay valid.
Hi Jes,
Thanks for doing that, esp. the 'supported' part.
drivers/char/mspec.c line 421
Quoted 3 lines
drivers/char/mspec.c new file +3
-0+MODULE_AUTHOR ("Silicon Graphics, Inc. <[email protected]>" ); +MODULE_DESCRIPTION ("Driver for SGI SN special memory operations" ); +MODULE_LICENSE ("GPL" );
---
~Randy
Hi,
Latest mspec driver patch to go with do_no_pfn.
Cheers,
Jes
This patch implements the special memory driver (mspec) based on the do_no_pfn approach. The driver is currently used only on SN2 hardware with special fetchop support but could be beneficial on other architectures using the uncached mode.
----
drivers/char/Kconfig | 8 drivers/char/Makefile | 1 drivers/char/mspec.c | 421 ++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 430 insertions(+)
drivers/char/Kconfig +8 -0
@@ -439,6 +439,14 @@ config SGI_MBCS If you have an SGI Altix with an attached SABrick say Y or M here, otherwise say N. +config MSPEC + tristate "Memory special operations driver" + depends on IA64 + help + If you have an ia64 and you want to enable memory special + operations support (formerly known as fetchop), say Y here, + otherwise say N. + source "drivers/serial/Kconfig" config UNIX98_PTYS
drivers/char/Makefile +1 -0
@@ -51,6 +51,7 @@ obj-$(CONFIG_VIOCONS) += viocons.o obj-$(CONFIG_VIOTAPE) += viotape.o obj-$(CONFIG_HVCS) += hvcs.o obj-$(CONFIG_SGI_MBCS) += mbcs.o +obj-$(CONFIG_MSPEC) += mspec.o obj-$(CONFIG_PRINTER) += lp.o obj-$(CONFIG_TIPAR) += tipar.o
drivers/char/mspec.c new file +421 -0
421 lines not on this page · raw message