Skip to contentSkip to conversation

LibPATA/ATA Errors Continue - Will there be a fix for this?

DISCUSSION Al Boldi 3 participants 3 messages Jun 20, 2006

lore
Share & tools
lore

Al Boldi

author
#0 lore raw
Quoted 17 lines · Justin Piszcz
Quoted 15 lines · Mark Lord
Quoted 2 lines · Justin Piszcz

Should someone comment this code out that produces the printk()'s as these are useless information as there is no problem with the disk?

MMm.. probably "barrier" commands that the drive doesn't like. Pity those messages don't also dump the failed opcode.

Quoted 8 lines
Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: error=0x04 {
DriveStatusError }
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: no sense translation
for status: 0x51
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: status=0x51 {

DriveReady SeekComplete Error }

Quoted 3 lines

Mark, what would be the proper direction to move towards? Is Jeff or another SATA/ATA maintainer going to have to look at this or is there something else I can do, or?

I once sent a patch to -mm:

Quoted 23 lines · Mark Lord
Quoted 10 lines · Al Boldi

Also apply this one to get rid of this message:

	hdb: set_drive_speed_status: status=0x40 { DriveReady }
	ide: failed opcode was: unknown

Maybe someone on the ide list can comment on this first though.

include/linux/ide.h typedef unsigned char byte; /* used ever · line 126

Quoted 8 lines
include/linux/ide.h renamed from include/linux/ide.h.orig +1 -1
@@ -120,7 +120,7 @@ typedef unsigned char	byte;	/* used ever
 #define IDE_BCOUNTL_REG		IDE_LCYL_REG
 #define IDE_BCOUNTH_REG		IDE_HCYL_REG
 
-#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
+#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
 #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
 #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
 #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)

Assuming hdb is a CDROM/optical drive, then this change makes sense for that. But I don't think it is a valid (good) change for regular ATA disks.

Quoted 2 lines

A more complex patch is required, one which correctly handles each drive type.

Thanks!

--
Al

#1 lore raw
Quoted 53 lines · Al Boldi
Quoted 17 lines · Justin Piszcz
Quoted 15 lines · Mark Lord
Quoted 2 lines · Justin Piszcz

Should someone comment this code out that produces the printk()'s as these are useless information as there is no problem with the disk?

MMm.. probably "barrier" commands that the drive doesn't like. Pity those messages don't also dump the failed opcode.

Quoted 8 lines
Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: status=0x51 {
DriveReady SeekComplete Error }
Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: error=0x04 {
DriveStatusError }
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: no sense translation
for status: 0x51
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: status=0x51 {

DriveReady SeekComplete Error }

Quoted 3 lines

Mark, what would be the proper direction to move towards? Is Jeff or another SATA/ATA maintainer going to have to look at this or is there something else I can do, or?

I once sent a patch to -mm:

Quoted 23 lines · Mark Lord
Quoted 10 lines · Al Boldi

Also apply this one to get rid of this message:

	hdb: set_drive_speed_status: status=0x40 { DriveReady }
	ide: failed opcode was: unknown

Maybe someone on the ide list can comment on this first though.

include/linux/ide.h typedef unsigned char byte; /* used ever · line 126

Quoted 8 lines
include/linux/ide.h renamed from include/linux/ide.h.orig +1 -1
@@ -120,7 +120,7 @@ typedef unsigned char	byte;	/* used ever
 #define IDE_BCOUNTL_REG		IDE_LCYL_REG
 #define IDE_BCOUNTH_REG		IDE_HCYL_REG
 
-#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
+#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
 #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
 #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
 #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)

Assuming hdb is a CDROM/optical drive, then this change makes sense for that. But I don't think it is a valid (good) change for regular ATA disks.

Quoted 2 lines

A more complex patch is required, one which correctly handles each drive type.

Thanks!

Quoted 9 lines

--
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Did the patch get applied to -mm?

#2 lore raw
In reply to Al Boldi
Quoted 3 lines · Al Boldi

I once sent a patch to -mm:

..

Quoted 10 lines
Quoted 10 lines

Review

Quoted 5 lines
(quoted diff) +1 -1
-#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
+#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
 #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
 #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
 #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)

Assuming hdb is a CDROM/optical drive, then this change makes sense for that. But I don't think it is a valid (good) change for regular ATA disks.

A more complex patch is required, one which correctly handles each drive type.

That patch was very ATAPI-specific, and would break other things. It also would not correctly help anything in Justin's case.

-ml