Skip to contentSkip to conversation

range checking for sleep states sent to /proc/acpi/sleep

PATCH-2.4 Willy Tarreau 1 participant 1 message Jun 20, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

Hi,

A range checking is missing in acpi_system_write_sleep() in kernel 2.4, and writing a large integer value to /proc/acpi/sleep will cause an oops. I could reproduce one this way :

   # echo 0x800000 >/proc/acpi/sleep

Fix extracted from the PaX patch.

Cheers,
Willy

---

 drivers/acpi/system.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

3cae76269fd00aa352255d872c8f461472ef8b56

drivers/acpi/system.c +1 -1
index a1e018c..26f7b68 100644
@@ -748,7 +748,7 @@ acpi_system_write_sleep (
 	
 	state = simple_strtoul(state_string, NULL, 0);
 	
-	if (!system->states[state])
+	if (state >= ACPI_S_STATE_COUNT || !system->states[state])
 		return_VALUE(-ENODEV);
 
 	/*
Signature · 1 line
1.3.3