Skip to contentSkip to conversation

+ netlink-remove-dead-code.patch added to -mm tree

DISCUSSION David Miller 2 participants 2 messages Jun 21, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

From: [email protected]
Date: Wed, 21 Jun 2006 13:33:58 -0700

net/netlink/af_netlink.c static int netlink_dump(struct sock *sk) · line 1385

Quoted 13 lines

diff -puN net/netlink/af_netlink.c~netlink-remove-dead-code net/netlink/af_netlink.c

net/netlink/af_netlink.c renamed from net/netlink/af_netlink.c~netlink-remove-dead-code +0 -3
@@ -1380,9 +1380,6 @@ static int netlink_dump(struct sock *sk)
 
 	netlink_destroy_callback(cb);
 	return 0;
-
-nlmsg_failure:
-	return -ENOBUFS;
 }
 
 int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,

Andrew, please type make before you commit things like this to your tree. This breaks the build.

These code labels are referenced internally by the netlink packet message macros, in this case the reference comes from NLMSG_NEW_ANSWER().

#2 lore raw
Quoted 15 lines · On Wed, 21 Jun 2006 13:53:39 -0700 (PDT) David Miller <[email protected]>…

From: [email protected]
Date: Wed, 21 Jun 2006 13:33:58 -0700

Quoted 12 lines

diff -puN net/netlink/af_netlink.c~netlink-remove-dead-code net/netlink/af_netlink.c

net/netlink/af_netlink.c renamed from net/netlink/af_netlink.c~netlink-remove-dead-code +0 -3
@@ -1380,9 +1380,6 @@ static int netlink_dump(struct sock *sk)
 
 	netlink_destroy_callback(cb);
 	return 0;
-
-nlmsg_failure:
-	return -ENOBUFS;
 }
 
Quoted 4 lines

net/netlink/af_netlink.c static int netlink_dump(struct sock *sk) · line 1385

Quoted 1 line
net/netlink/af_netlink.c renamed from net/netlink/af_netlink.c~netlink-remove-dead-code +0 -0
 int netlink_dump_start(struct sock *ssk, struct sk_buff *skb,

Andrew, please type make before you commit things like this to your tree.

Nope. I build-test in batches, not after every patch.