Skip to contentSkip to conversation

UML - fix uptime

PATCH Applied Jeff Dike 2 participants 4 messages Jun 20, 2006 – Jun 21, 2006 User-mode Linux (UML)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 1/1 UML - fix uptime

Please consider this for 2.6.17-stable. It made -mm briefly, but missed 2.6.17. It fixes the value of uptime, which was broken by a patch late in 2.6.17-rc.

The use of unsigned instead of unsigned here broke the calculations on negative numbers that are involved in calculating wall_to_monotonic.

arch/um/kernel/time_kern.c +1 -1
Index: linux-2.6.17-mm/arch/um/kernel/time_kern.c
===================================================================
@@ -87,7 +87,7 @@ void timer_irq(union uml_pt_regs *regs)
 
 void time_init_kern(void)
 {
-	unsigned long long nsecs;
+	long long nsecs;
 
 	nsecs = os_nsecs();
 	set_normalized_timespec(&wall_to_monotonic, -nsecs / BILLION,

_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

author
#2 lore raw
Quoted 4 lines · Chris Wright
Quoted 1 line · * Jeff Dike ([email protected]) wrote:

The use of unsigned instead of unsigned here broke the calculations on

             ^^^^^^^^            ^^^^^^^^

Hard to imagine how that would cause a problem ;-)

Heh, feel free to fix.

Quoted 1 line

Queued for -stable, thanks.

Thanks.

Jeff

_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#3 lore raw
Quoted 7 lines · * Jeff Dike ([email protected]) wrote:
Quoted 4 lines · Chris Wright
Quoted 1 line · * Jeff Dike ([email protected]) wrote:

The use of unsigned instead of unsigned here broke the calculations on

             ^^^^^^^^            ^^^^^^^^

Hard to imagine how that would cause a problem ;-)

Heh, feel free to fix.

Thanks, I did when I queued it up.
-chris

_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel