i386: halt the CPU on serious errors
In-Reply-To: <[email protected]>
Quoted 11 lines · Andreas Mohr
Thanks for the very fast patch, but:
Review
Quoted 5 lines
/* Assume hlt works */(quoted diff) +2
-2- halt(); - for(;;); + for (;;) + halt();The comment above seems to hint at this code in
arch/i386/kernel/smp.c/stop_this_cpu()which does proper hlt checks:
Quoted 6 lines
if (cpu_data[smp_processor_id()].hlt_works_ok) for(;;) halt(); for (;;);So I'm unsure what happens if hlt is not supported properly. Maybe there's an invalid opcode exception in a loop then.
Some ancient CPUs never wake up on interrupt after a halt. See
include/asm-i386/bugs.h::check_hlt().
Signature · 2 lines
Chuck "You can't read a newspaper if you can't read." --George W. Bush