Skip to contentSkip to conversation

[2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line

PATCH NAK Predrag Ivanovic 2 participants 2 messages Jun 22, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [2.6.17]drivers/media/video/bt8xx/bttvp.h has wrong include line

Hi.
Trivial patch, really.
Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
------

bttvp.h.new renamed from bttvp.h +1 -1
@@ -48,7 +48,7 @@
 
 #include "bt848.h"
 #include "bttv.h"
-#include "btcx-risc.h"
+#include "../btcx-risc.h"
 
 #ifdef __KERNEL__
 

-----------
Pedja

Signature · 3 lines
 Recent studies suggest that running /usr/bin/coffee from cron at regular
 intervals can be more effective at enhancing uptime than launching a big
 coffeed process at startup.
#1 lore raw
Quoted 16 lines · Predrag Ivanovic

Hi.
Trivial patch, really.
Fixes include line in bttvp.h(btcx-risc.h is in parent dir).
------

bttvp.h.new renamed from bttvp.h +1 -2
@@ -48,7 +48,7 @@
 
 #include "bt848.h"
 #include "bttv.h"
-#include "btcx-risc.h"
+#include "../btcx-risc.h"
 
 #ifdef __KERNEL__
 
-----------
Quoted 2 lines

Pedja

NACK.

Please see drivers/media/video/bt8xx/Makefile

You will notice the following line:

EXTRA_CFLAGS += -Idrivers/media/video

This instructs the compiler to find some other required headers in drivers/media/video (such as btcx-risc.h)

Your patch is unnecessary, and it is bad practice to use ".." inside a header includes path, IMHO at least.

In addition, please see the guidelines in Documentation/SubmittingPatches before you send any future patches. We cannot accept patches into the linux kernel without a proper developer's certificate of origin.

Thank you for the effort, though :-)

Regards,

Michael Krufky