Skip to contentSkip to conversation

intelfb: enable on x86_64

DISCUSSION Dave Jones 1 participant 2 messages Jun 22, 2006 1 message not in the archive Framebuffer layer

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 20 lines · Linux Kernel

commit 0c187addabbaf93512902442b4a90140a21b0ddc
tree 40cd618a76474ec9ba2cfde129315c7ebbaf4f9f
parent 16109b3f4c1f2635afd32eb6d49348590de2cb25
author Dave Airlie <[email protected]> Thu, 23 Mar 2006 11:20:08 +1100 committer Dave Airlie <[email protected]> Mon, 03 Apr 2006 11:43:28 +1000

intelfb: enable on x86_64

i945G chipsets supports 64-bit.

 drivers/video/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/video/Kconfig +0 -0
index f87c017..190adce 100644

drivers/video/Kconfig config FB_I810_I2C · line 747

Quoted 8 lines
drivers/video/Kconfig +1 -1
@@ -741,7 +741,7 @@ config FB_I810_I2C
 
 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G support (EXPERIMENTAL)"
-	depends on FB && EXPERIMENTAL && PCI && X86_32
+	depends on FB && EXPERIMENTAL && PCI && X86
 	select AGP
 	select AGP_INTEL
 	select FB_MODE_HELPERS

This turned into an unpleasant surprise.
If you select for eg, IOMMU=y and CONFIG_AGP=y, and CONFIG_FB_INTEL=m, then CONFIG_AGP gets silently turned into a =m, and the build fails with this..

arch/x86_64/kernel/pci-gart.c:619: undefined reference to agp_amd64_init' arch/x86_64/kernel/pci-gart.c:619: undefined reference to agp_bridge' arch/x86_64/kernel/pci-gart.c:619: undefined reference to `agp_copy_info'

Dave

Signature · 1 line
http://www.codemonkey.org.uk
author
#2 lore raw
Quoted 6 lines · Dave Jones

If you select for eg, IOMMU=y and CONFIG_AGP=y, and CONFIG_FB_INTEL=m, then CONFIG_AGP gets silently turned into a =m, and the build fails with this..

arch/x86_64/kernel/pci-gart.c:619: undefined reference to agp_amd64_init' arch/x86_64/kernel/pci-gart.c:619: undefined reference to agp_bridge' arch/x86_64/kernel/pci-gart.c:619: undefined reference to `agp_copy_info'

This seems to work around it..

drivers/video/Kconfig renamed from drivers/video/Kconfig~ +2 -2
@@ -807,8 +807,8 @@ config FB_I810_I2C
 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G support (EXPERIMENTAL)"
 	depends on FB && EXPERIMENTAL && PCI && X86 && !VGA_NOPROBE
-	select AGP
-	select AGP_INTEL
+	depends on AGP
+	depends on AGP_INTEL
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
Signature · 1 line
http://www.codemonkey.org.uk