Skip to contentSkip to conversation

kmalloc argument switcheroo in recent 53c700 change.

PATCH Dave Jones 1 participant 1 message Jun 22, 2006 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw

Review

Quoted 13 lines · Linux Kernel

commit 67d59dfdeb21df2c16dcd478b66177e91178ecd0
tree ae85703651d81740f4a6cd398f9dd4d6aabe6a2f
parent 6db874fbdbedba5e15e76cc03b42f52ea70338c0
author James Bottomley <[email protected]> Wed, 14 Jun 2006 07:31:19 -0500 committer James Bottomley <[email protected]> Tue, 20 Jun 2006 05:34:01 -0500

[SCSI] 53c700: remove reliance on deprecated cmnd fields
...

(quoted diff) +4 -0
+	SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
+
+	if (!SDp->hostdata)
+		return -ENOMEM;

"I'll take reversed arguments for $100 please Alex".

drivers/scsi/53c700.c renamed from drivers/scsi/53c700.c~ +1 -1
@@ -2044,7 +2044,7 @@ NCR_700_slave_configure(struct scsi_devi
 	struct NCR_700_Host_Parameters *hostdata = 
 		(struct NCR_700_Host_Parameters *)SDp->host->hostdata[0];
 
-	SDp->hostdata = kmalloc(GFP_KERNEL, sizeof(struct NCR_700_sense));
+	SDp->hostdata = kmalloc(sizeof(struct NCR_700_sense), GFP_KERNEL);
 
 	if (!SDp->hostdata)
 		return -ENOMEM;
Signature · 1 line
http://www.codemonkey.org.uk