Skip to contentSkip to conversation

broken null test in s390 claw driver

PATCH Dave Jones 1 participant 1 message Jun 23, 2006

Subsystems (3)
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Whoops, better hope this never gets passed a null dev in its current state.

drivers/s390/net/claw.c renamed from drivers/s390/net/claw.c~ +1 -1
@@ -529,7 +529,7 @@ claw_open(struct net_device *dev)
         printk(KERN_INFO "%s:%s Enter  \n",dev->name,__FUNCTION__);
 #endif
 	CLAW_DBF_TEXT(4,trace,"open");
-	if (!dev | (dev->name[0] == 0x00)) {
+	if (!dev || (dev->name[0] == 0x00)) {
 		CLAW_DBF_TEXT(2,trace,"BadDev");
 	 	printk(KERN_WARNING "claw: Bad device at open failing \n");
 		return -ENODEV;
Signature · 1 line
http://www.codemonkey.org.uk