modpost change proposed
Hello
If the modpost has error it dumps core:
modpost: vmlinux no symtab?/bin/sh: line 1: 28307 Aborted (core dumped)scripts/mod/modpost -o /home/clock/edb9302/cirrus-arm-linux-1.0.7/linux-2.6.8.1/Module.symvers vmlinux drivers/net/wireless/hermes.o drivers/net/wireless/orinoco.o drivers/net/wireless/orinoco_cs.o drivers/usb/gadget/g_file_storage.o make[1]: *** [__modpost] Error 134
I suggest the abort(); to be everywhere replaced with exit(1) for the following reasons:
1) it's customary
2) core dumping looks scary
3) the core takes up space on disk
Regards,
CL<
Quoted 9 lines · Karel Kulhavy
If the modpost has error it dumps core:
modpost: vmlinux no symtab?/bin/sh: line 1: 28307 Aborted (core dumped)scripts/mod/modpost-o/home/clock/edb9302/cirrus-arm-linux-1.0.7/linux-2.6.8.1/Module.symversvmlinuxdrivers/net/wireless/hermes.odrivers/net/wireless/orinoco.odrivers/net/wireless/orinoco_cs.odrivers/usb/gadget/g_file_storage.omake[1]: *** [__modpost] Error 134
Quoted 3 lines
I suggest the
abort(); to be everywhere replaced with exit(1) for the following reasons:
1) it's customary
It's not. In case of a serious error, abort() gives you the chance to do a post mortem analysis with a debugger, exit() doesn't. I do agree that the use of abort() in modpost is not necessary. Try this patch (against 2.6.17):
commit 726ee2748969fb2d40b45de36dd56a5abea37954
Author: Erik Mouw <[email protected]> Date: Fri Jun 23 14:04:52 2006 +0200
modpost: change abort() into exit()
The perror() above the abort() tells enough about the failure, no need to dump core (a post mortem analysis on the core file won't give extra information about the failure). Suggested by Karel Kulhavy.
scripts/mod/modpost.c +1 -1
@@ -283,7 +283,7 @@ static void parse_elf(struct elf_info *i hdr =grab_file (filename, &info->size);if (!hdr) {perror (filename); -abort (); +exit (1 ); } info->hdr = hdr;if (info->size <sizeof (*hdr))
Quoted 1 line
2) core dumping looks scary
If it scares you, disable it. "limit coredumpsize 0" in (t)csh, or "ulimit -c 0" in bash.
Quoted 1 line
3) the core takes up space on disk
If you don't like it, disable it.
Erik
Signature · 2 lines
+-- Erik Mouw -- www.harddisk-recovery.com -- +31 70 370 12 90 -- | Lab address: Delftechpark 26, 2628 XH, Delft, The Netherlands
Quoted 4 lines · Erik Mouw
Quoted 4 lines
I suggest the
abort(); to be everywhere replaced with exit(1) for the following reasons:
1) it's customary
Did so in scripts/* - thanks.
Sam