Skip to contentSkip to conversation

lock validator: fix qeth compile warning

PATCH In review Heiko Carstens 2 participants 2 messages Jun 23, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 4/4 lock validator: fix qeth compile warning

From: Heiko Carstens <[email protected]>

Add #ifdef CONFIG_LOCKDEP to avoid compile warning.

---

 drivers/s390/net/qeth_main.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/s390/net/qeth_main.c +2 -0
Index: linux-2.6.17-mm1/drivers/s390/net/qeth_main.c
===================================================================
@@ -85,7 +85,9 @@ static debug_info_t *qeth_dbf_qerr = NUL
 
 DEFINE_PER_CPU(char[256], qeth_dbf_txt_buf);
 
+#ifdef CONFIG_LOCKDEP
 static struct lockdep_type_key qdio_out_skb_queue_key;
+#endif
 
 /**
  * some more definitions and declarations
#1 lore raw

drivers/s390/net/qeth_main.c static debug_info_t *qeth_dbf_qerr = NUL · line 90

Quoted 3 lines · Heiko Carstens
drivers/s390/net/qeth_main.c +2 -0
+#ifdef CONFIG_LOCKDEP
 static struct lockdep_type_key qdio_out_skb_queue_key;
+#endif

ok, that's fine for now. I'm cleaning this up via introducing per-lock-variant keys. But maybe the best would be to offer the lock validator in a binary way only - either for all lock variants at once, or for none at all?

Ingo