powerpc: Extra sanity check in EEH code
Subsystems (2)
PATCH 1/1 powerpc: Extra sanity check in EEH code
From: Nathan Lynch <[email protected]>
Don't dereference a device node that isn't there. A "shouldn't happen" case, but someone ran into it with a possibly misconfigured device tree.
Signed-off-by Nathan Lynch <[email protected]>
Signed-off-by Anton Blanchard <[email protected]>
---
arch/powerpc/platforms/pseries/eeh_cache.c +2 -0
@@ -304,6 +304,8 @@ void __init pci_addr_cache_build(void)pci_addr_cache_insert_device (dev); dn =pci_device_to_OF_node (dev); +if (!dn) +continue ;pci_dev_get (dev);/* matching put is in eeh_remove_device() */ PCI_DN (dn)->pcidev = dev; }
As nominal maintainer of the EEH code, I'll add
Signed-off-by Linas Vepstas <[email protected]>
Quoted 24 lines · Anton Blanchard
From: Nathan Lynch <[email protected]>
Don't dereference a device node that isn't there. A "shouldn't happen" case, but someone ran into it with a possibly misconfigured device tree.
Signed-off-by Nathan Lynch <[email protected]>Signed-off-by Anton Blanchard <[email protected]>---
Index:
build/arch/powerpc/platforms/pseries/eeh_cache.c
===================================================================arch/powerpc/platforms/pseries/eeh_cache.c +2
-0@@ -304,6 +304,8 @@ void __init pci_addr_cache_build(void)pci_addr_cache_insert_device (dev); dn =pci_device_to_OF_node (dev); +if (!dn) +continue ;pci_dev_get (dev);/* matching put is in eeh_remove_device() */ PCI_DN (dn)->pcidev = dev; }