Skip to contentSkip to conversation

fix "Trying to free nonexistent resource" format string

PATCH In review Andy Isaacson 2 participants 2 messages Jun 21, 2006 – Jun 24, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix "Trying to free nonexistent resource" format string

In 2.6.17-mm1, the patch gregkh-pci-64bit-resource-fix-up-printks-for-resources-in-arch-and-core-code.patch has some formatting bugs.
* converts %08x into %16llx, which results in space-padding rather than zero-padding.
* some casts are insufficiently touchy-feely with their castees.

This patch fixes them.

kernel/resource.c +2 -2
Index: q-2.6.17-mm1/kernel/resource.c
===================================================================
@@ -558,8 +558,8 @@
 	write_unlock(&resource_lock);
 
 	printk(KERN_WARNING "Trying to free nonexistent resource "
-		"<%16llx-%16llx>\n", (unsigned long long)start,
-		(unsigned long long) end);
+		"<%016llx-%016llx>\n", (unsigned long long)start,
+		(unsigned long long)end);
 }
 
 EXPORT_SYMBOL(__release_region);
#1 lore raw
Quoted 10 lines · Andy Isaacson

In 2.6.17-mm1, the patch gregkh-pci-64bit-resource-fix-up-printks-for-resources-in-arch-and-core-code.patch has some formatting bugs.
* converts %08x into %16llx, which results in space-padding rather than zero-padding.
* some casts are insufficiently touchy-feely with their castees.

This patch fixes them.

Thanks, I've merged this in with the original patch and added your Signed-off-by to it.

thanks,

greg k-h