Skip to contentSkip to conversation

-git: Why is drivers/net/wan/hdlc_generic.c:hdlc_setup() exported?

PATCH In review Adrian Bunk 2 participants 4 messages Jun 25, 2006 – Nov 26, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Commit 4a31e348e3ecaf54c50240109ac4574b180f8840 added an EXPORT_SYMBOL(hdlc_setup) with the justification
hdlc_setup() is now EXPORTed as per David's request.

Is a usage of this export pending for the near future or could this export be reverted until a user is submitted for inclusion?

TIA
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
maintainer
#1 lore raw
Quoted 3 lines · Adrian Bunk

hdlc_setup() is now EXPORTed as per David's request.

Is a usage of this export pending for the near future

I'm told it is.

Signature · 1 line
Krzysztof Halasa
#2 lore raw

PATCH 1/1 make hdlc_setup() static again

Quoted 7 lines · Krzysztof Halasa
Quoted 3 lines · Adrian Bunk

hdlc_setup() is now EXPORTed as per David's request.

Is a usage of this export pending for the near future

I'm told it is.

It's still not used...

So let's unexport it again until some driver that actually uses it shows up.

Quoted 1 line

Krzysztof Halasa

cu
Adrian

<-- snip -->

hdlc_setup was exported, but this export was never used.

If adriver using it actually shows up it can still be exported again.

drivers/net/wan/hdlc.c renamed from drivers/net/wan/hdlc.c.old +1 -2
@@ -222,7 +222,7 @@
 	return -EINVAL;
 }
 
-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
 {
 	hdlc_device *hdlc = dev_to_hdlc(dev);
 
@@ -325,7 +325,6 @@
 EXPORT_SYMBOL(hdlc_open);
 EXPORT_SYMBOL(hdlc_close);
 EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
 EXPORT_SYMBOL(alloc_hdlcdev);
 EXPORT_SYMBOL(unregister_hdlc_device);
 EXPORT_SYMBOL(register_hdlc_protocol);
maintainer
#3 lore raw

Re: [2.6 patch] make hdlc_setup() static again

Quoted 3 lines · Adrian Bunk

It's still not used...

So let's unexport it again until some driver that actually uses it shows up.

Fair enough.

Signature · 1 line
Krzysztof Halasa