ppc32 with CONFIG_KEXEC broken
various things like 'reserve_crashkernel' are referenced, but only exist in arch/powerpc/kernel/machine_kexec_64.c.
( This is using the mercurial repository from
http://www.kernel.org/hg/linux-2.6/, which I believe tracks git )
Quoted 3 lines · Troy Benjegerdes
various things like '
reserve_crashkernel' are referenced, but only exist inarch/powerpc/kernel/machine_kexec_64.c.
I think for ppc32 the framework is present for kexec/kdump but nobody is actively testing/maintaining it as of today.
Thanks
Vivek
Quoted 7 lines · Vivek Goyal
Quoted 3 lines · Troy Benjegerdes
various things like '
reserve_crashkernel' are referenced, but only exist inarch/powerpc/kernel/machine_kexec_64.c.I think for ppc32 the framework is present for kexec/kdump but nobody is actively testing/maintaining it as of today.
Even if it's not actively being tested, introducing changes for ppc64 that break compiles on ppc32 is going to make people unhappy.
PATCH 1/1 powerpc: build fix for ppc32 with CONFIG_KEXEC
In reply to Vivek GoyalQuoted 12 lines · Vivek Goyal
Quoted 5 lines · Troy Benjegerdes
various things like '
reserve_crashkernel' are referenced, but only exist inarch/powerpc/kernel/machine_kexec_64.c.I think for ppc32 the framework is present for kexec/kdump but nobody is actively testing/maintaining it as of today.
At present, even though kexec support is included for PPC32, I believe, it has been actively tested/maintained only on gamecube.
Michael, if you are OK with this patch, please send it to upstream. Thanks
Haren
arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function `early_init_devtree':
: undefined reference to `reserve_crashkernel'
arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function `early_init_devtree':
: undefined reference to `overlaps_crashkernel'
This patch will fix the above build errors on ppc32 with CONFIG_KEXEC. Both reserve_crashkernel() and overlaps_crashkernel() should be moved to machine_kexec.c() after the kdump support is included on ppc32.
Quoted 8 lines
Thanks
Vivek
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot
arch/powerpc/kernel/machine_kexec_32.c renamed from arch/powerpc/kernel/machine_kexec_32.c.orig +13 -0
@@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct {return 0 ; } + +/* +* FIXME: Move the following functions to machine_kexec.c after +* kdump support is included on ppc32. +*/ +void __init reserve_crashkernel (void ) +{ +} + +int overlaps_crashkernel (unsigned long start,unsigned long size) +{ +return 0 ; +}
Quoted 2 lines · Troy Benjegerdes
various things like '
reserve_crashkernel' are referenced, but only exist inarch/powerpc/kernel/machine_kexec_64.c.
Can you send a patch that prevents people from turning KEXEC on when using that arch? The arch/ppc stuff is in a state of limbo at the moment until it all gets migrated to arch/powerpc.
thx,
josh