Skip to contentSkip to conversation

linux-2.6.17.1: undefined reference to `online_page'

DISCUSSION Toralf Förster 1 participant 1 message Jun 26, 2006

lore
Share & tools
lore
#0 lore raw

---------- Weitergeleitete Nachricht ----------

Subject: Re: linux-2.6.17.1: undefined reference to `online_page'
Date: Monday 26 June 2006 11:14
From: Toralf Förster <[email protected]>
To: Yasunori Goto <[email protected]>

Am Monday 26 June 2006 09:39 schrieben Sie:

Quoted 54 lines
Quoted 27 lines

In-Reply-To: <[email protected]>

Quoted 15 lines · Toralf Foerster

I got the compile error :

...

  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1

mm/built-in.o: In function `online_pages':
: undefined reference to `online_page'
make: *** [.tmp_vmlinux1] Error 1

with this config:

CONFIG_X86_32=y

Quoted 7 lines

CONFIG_NOHIGHMEM=y

CONFIG_SPARSEMEM_MANUAL=y
CONFIG_SPARSEMEM=y
CONFIG_HAVE_MEMORY_PRESENT=y
CONFIG_SPARSEMEM_STATIC=y
CONFIG_MEMORY_HOTPLUG=y

Quoted 3 lines

Yes, that config is broken. mm/memory_hotplug.c::online_pages() calls online_page() but without HIGHMEM that doesn't get built and no dummy function gets defined.

Toralf-san. How is this patch?
Or do you want to use memory hotplug without highmem?

Bye.

---

add_memory() for i386 add memory to highmem. So, if CONFIG_HIGHMEM is not set, CONFIG_MEMORY_HOTPLUG shouldn't be set.

---
 mm/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.17/mm/Kconfig
===================================================================

mm/Kconfig config SPARSEMEM_EXTREME · line 121

Quoted 8 lines
mm/Kconfig +1 -1
@@ -115,7 +115,7 @@ config SPARSEMEM_EXTREME
 # eventually, we can have this option just 'select SPARSEMEM'
 config MEMORY_HOTPLUG
 	bool "Allow for memory hot-add"
-	depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND
+	depends on SPARSEMEM && HOTPLUG && !SOFTWARE_SUSPEND && !(X86_32 && !HIGHMEM)
 
 comment "Memory hotplug is currently incompatible with Software Suspend"
 	depends on SPARSEMEM && HOTPLUG && SOFTWARE_SUSPEND

Works fine with that patch, thanks :-)

BTW, I created the .config using the command sequence "make randconfig && <adapt .config to local machine> && make oldconfig".

Signature · 9 lines
MfG/Sincerely
Toralf Förster


-------------------------------------------------------

-- 
MfG/Sincerely
Toralf Förster