[uml-devel] [PATCH] Fix UML build on i386 Ubuntu Dapper

Nishanth Aravamudan

author

2006-06-26 22:02 UTC #0 lore raw

PATCH 1/1 Fix UML build on i386 Ubuntu Dapper

Hi Jeff,

I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.

Signed-off-by Nishanth Aravamudan <[email protected]>

arch/um/kernel/vmlinux.lds.S +1 -0

diff -urpN 2.6.17/arch/um/kernel/vmlinux.lds.S 2.6.17-dev/arch/um/kernel/vmlinux.lds.S
@@ -1,4 +1,5 @@
 #include <linux/config.h>
+#undef i386
 #ifdef CONFIG_LD_SCRIPT_STATIC
 #include "uml.lds.S"
 #else

arch/um/Makefile-x86_64 +5 -2

diff -urpN 2.6.17/arch/um/Makefile-x86_64 2.6.17-dev/arch/um/Makefile-x86_64
@@ -6,9 +6,11 @@ START := 0x60000000
 
 #We #undef __x86_64__ for kernelspace, not for userspace where
 #it's needed for headers to work!
-CFLAGS += -U__$(SUBARCH)__ -fno-builtin
-USER_CFLAGS += -fno-builtin
+CFLAGS += -U__$(SUBARCH)__ -fno-builtin -m64
+USER_CFLAGS += -fno-builtin -m64
 CHECKFLAGS  += -m64
+AFLAGS += -m64
+LDFLAGS += -m elf_x86_64
 
 ELF_ARCH := i386:x86-64
 ELF_FORMAT := elf64-x86-64

@@ -16,3 +18,4 @@ ELF_FORMAT := elf64-x86-64
 # Not on all 64-bit distros /lib is a symlink to /lib64. PLD is an example.
 
 LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
+LINK-y += -m64

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Blaisorblade

2006-06-27 14:57 UTC #1 lore raw

Quoted 7 lines · Nishanth Aravamudan

Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).

Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...

Quoted 4 lines

Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>

The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for i386 kernels. However, if UML builds and runs on already supported configurations, the patch is almost ok - but the original comment must be added for the #undef:
/* in case the preprocessor is a 32bit one */

Quoted 34 lines

diff -urpN 2.6.17/arch/um/kernel/vmlinux.lds.S
2.6.17-dev/arch/um/kernel/vmlinux.lds.S ---
2.6.17/arch/um/kernel/vmlinux.lds.S 2006-06-17 18:49:35.000000000 -0700 +++
2.6.17-dev/arch/um/kernel/vmlinux.lds.S 2006-06-26 14:55:45.000000000 -0700
arch/um/kernel/vmlinux.lds.S +1 -0
@@ -1,4 +1,5 @@
 #include <linux/config.h>
+#undef i386
 #ifdef CONFIG_LD_SCRIPT_STATIC
 #include "uml.lds.S"
 #else
diff -urpN 2.6.17/arch/um/Makefile-x86_64
2.6.17-dev/arch/um/Makefile-x86_64 ---
2.6.17/arch/um/Makefile-x86_64 2006-06-17 18:49:35.000000000 -0700 +++
2.6.17-dev/arch/um/Makefile-x86_64 2006-06-26 14:49:01.000000000 -0700 @@
-6,9 +6,11 @@ START := 0x60000000
#We #undef __x86_64__ for kernelspace, not for userspace where #it's needed for headers to work!
arch/um/Makefile-x86_64 +4 -2
-CFLAGS += -U__$(SUBARCH)__ -fno-builtin
-USER_CFLAGS += -fno-builtin
+CFLAGS += -U__$(SUBARCH)__ -fno-builtin -m64
+USER_CFLAGS += -fno-builtin -m64
 CHECKFLAGS  += -m64
+AFLAGS += -m64
+LDFLAGS += -m elf_x86_64
 
 ELF_ARCH := i386:x86-64
 ELF_FORMAT := elf64-x86-64
@@ -16,3 +18,4 @@ ELF_FORMAT := elf64-x86-64
 # Not on all 64-bit distros /lib is a symlink to /lib64. PLD is an
example.
LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
+LINK-y += -m64

Signature · 15 lines

Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-27 18:31 UTC #2 lore raw

Quoted 9 lines · Blaisorblade

Quoted 7 lines · Nishanth Aravamudan
Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).

Quoted 3 lines

Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...

Indeed :)

Quoted 10 lines

Quoted 4 lines
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>
The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for i386 kernels. However, if UML builds and runs on already supported configurations, the patch is almost ok - but the original comment must be added for the #undef: /* in case the preprocessor is a 32bit one */

Ah yes, sorry, I'll add the comment. I found if I did not add the #undef, I got a broken build (the "1:x86_64" issue in the above thread, when it should be "i386:x86_64"):

LD .tmp_vmlinux1
/usr/bin/ld:arch/um/kernel/vmlinux.lds:251: syntax error
collect2: ld returned 1 exit status
KSYM .tmp_kallsyms1.S
nm: '.tmp_vmlinux1': No such file
No valid symbol.

After discovering SUBARCH, I rebuilt my tree as an i386 UML and it successfully completed with this patch. If someone could test a native i386 build as well, just to be sure?

Updated patch follows.

I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail. Compile- and boot-tested with SUBARCH=x86_64 (native) and compile-tested and boot-tested with SUBARCH=i386.

Signed-off-by Nishanth Aravamudan <[email protected]>

arch/um/kernel/vmlinux.lds.S +2 -0

diff -urpN 2.6.17/arch/um/kernel/vmlinux.lds.S 2.6.17-dev/arch/um/kernel/vmlinux.lds.S
@@ -1,4 +1,6 @@
 #include <linux/config.h>
+/* in case the preprocessor is a 32bit one */
+#undef i386
 #ifdef CONFIG_LD_SCRIPT_STATIC
 #include "uml.lds.S"
 #else

arch/um/Makefile-x86_64 +5 -2

diff -urpN 2.6.17/arch/um/Makefile-x86_64 2.6.17-dev/arch/um/Makefile-x86_64
@@ -6,9 +6,11 @@ START := 0x60000000
 
 #We #undef __x86_64__ for kernelspace, not for userspace where
 #it's needed for headers to work!
-CFLAGS += -U__$(SUBARCH)__ -fno-builtin
-USER_CFLAGS += -fno-builtin
+CFLAGS += -U__$(SUBARCH)__ -fno-builtin -m64
+USER_CFLAGS += -fno-builtin -m64
 CHECKFLAGS  += -m64
+AFLAGS += -m64
+LDFLAGS += -m elf_x86_64
 
 ELF_ARCH := i386:x86-64
 ELF_FORMAT := elf64-x86-64

@@ -16,3 +18,4 @@ ELF_FORMAT := elf64-x86-64
 # Not on all 64-bit distros /lib is a symlink to /lib64. PLD is an example.
 
 LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
+LINK-y += -m64

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-28 00:48 UTC #3 lore raw

Quoted 10 lines · Nishanth Aravamudan

Quoted 9 lines · Blaisorblade
Quoted 7 lines · Nishanth Aravamudan
Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).

Quoted 13 lines

Quoted 3 lines
Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...
Indeed :)
Quoted 7 lines
Quoted 4 lines
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>
The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for

Hrm, I somehow overlooked the CPPFLAGS bit. Is it necessary? That wasn't changed for x86_64 and having not changed it for UML, it doesn't appear to have prevented the build from working on both x86_64 and i386 SUBARCHs here.

Thanks,
Nish

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Blaisorblade

2006-06-28 10:14 UTC #4 lore raw

Quoted 22 lines · Nishanth Aravamudan

Quoted 21 lines · Nishanth Aravamudan
Quoted 9 lines · Blaisorblade
Quoted 7 lines · Nishanth Aravamudan
Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Quoted 3 lines
Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...
Indeed :)
Quoted 5 lines
Quoted 4 lines
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>

Quoted 7 lines

Quoted 2 lines
Quoted 2 lines
The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for
Hrm, I somehow overlooked the CPPFLAGS bit. Is it necessary? That wasn't changed for x86_64 and having not changed it for UML, it doesn't appear to have prevented the build from working on both x86_64 and i386 SUBARCHs here.

It shouldn't go in the general CPPFLAGS indeed.
I think that -m64 in the preprocessor command used to build vmlinux.lds.S would be cleaner than #undef i386... test it by preprocessing by hand and report, I'll code the CPPFLAGS_vmlinux.lds.S = -m64 assignment (if it is exactly this way) if it works.

Anyway, this is minor refinement, the patch is otherwise ok.

Signature · 15 lines

Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-29 20:56 UTC #5 lore raw

Quoted 33 lines · Blaisorblade

Quoted 23 lines · Nishanth Aravamudan
Quoted 22 lines · Nishanth Aravamudan
Quoted 10 lines · Blaisorblade
Quoted 8 lines · Nishanth Aravamudan
Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Quoted 3 lines
Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...
Indeed :)
Quoted 5 lines
Quoted 4 lines
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for
Hrm, I somehow overlooked the CPPFLAGS bit. Is it necessary? That wasn't changed for x86_64 and having not changed it for UML, it doesn't appear to have prevented the build from working on both x86_64 and i386 SUBARCHs here.

Quoted 5 lines

It shouldn't go in the general CPPFLAGS indeed. I think that -m64 in the preprocessor command used to build vmlinux.lds.S would be cleaner than #undef i386... test it by preprocessing by hand and report, I'll code the CPPFLAGS_vmlinux.lds.S = -m64 assignment (if it is exactly this way) if it works.

Just for clarity's sake, the reason the #undef is there, as far as I can tell, is otherwise the preprocessor (I'm assuming) goes and makes the output specification as 1:x86_64 instead of i386:x86_64. If one were then to go and manually change the 1 to i386 and then reissue make, the kernel will build just fine.

I removed the #undef i386 from vmlinux.ld.S and added a

CPPFLAGS += -m64

to arch/um/Makefile-x86_64

The build completed fine here.

I wonder if a patch against x86_64 to remove the #undef there should also be applied? I'll take a look.

Thanks,
Nish

---

I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.

This is the patch I'm currently using. I don't know if putting the CPPFLAGS in the Makefile-x86_64 is bad or not, I'll leave that up to those with more knowledge to decide.

Signed-off-by Nishanth Aravamudan <[email protected]>

arch/um/Makefile-x86_64 +6 -2

diff -urpN 2.6.17/arch/um/Makefile-x86_64 2.6.17-dev/arch/um/Makefile-x86_64
@@ -6,9 +6,12 @@ START := 0x60000000
 
 #We #undef __x86_64__ for kernelspace, not for userspace where
 #it's needed for headers to work!
-CFLAGS += -U__$(SUBARCH)__ -fno-builtin
-USER_CFLAGS += -fno-builtin
+CFLAGS += -U__$(SUBARCH)__ -fno-builtin -m64
+USER_CFLAGS += -fno-builtin -m64
 CHECKFLAGS  += -m64
+AFLAGS += -m64
+LDFLAGS += -m elf_x86_64
+CPPFLAGS += -m64
 
 ELF_ARCH := i386:x86-64
 ELF_FORMAT := elf64-x86-64

@@ -16,3 +19,4 @@ ELF_FORMAT := elf64-x86-64
 # Not on all 64-bit distros /lib is a symlink to /lib64. PLD is an example.
 
 LINK-$(CONFIG_LD_SCRIPT_DYN) += -Wl,-rpath,/lib64
+LINK-y += -m64

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-29 21:49 UTC #6 lore raw

Quoted 34 lines · Nishanth Aravamudan

Quoted 33 lines · Blaisorblade
Quoted 31 lines · Nishanth Aravamudan
Quoted 11 lines · Nishanth Aravamudan
Quoted 10 lines · Blaisorblade
Quoted 8 lines · Nishanth Aravamudan
Hi Jeff,
I run an x86_64 kernel with i386 userspace (Ubuntu Dapper) and decided to try out UML today. I found that UML wasn't quite aware of biarch compilers (which Ubuntu i386 ships). A fix similar to what was done for x86_64 should probably be committed (see
http://marc.theaimsgroup.com/?l=linux-kernel&m=113425940204010&w=2).
Quoted 14 lines
Quoted 3 lines
Ok, it seemed strange but I understand the stuff... that's very interesting as this is the setup I'd wished to have since ages. I'll switch to it ASAP...
Indeed :)
Quoted 8 lines
Quoted 4 lines
Without the FLAGS changes, the build will fail at a number of places and without the LINK change, the final link will fail.
Signed-off-by Nishanth Aravamudan <[email protected]>
The first hunk (#undef i386) should be unnecessary given you specify -m64 (add it to CPPFLAGS too). Also it can/could be problematic for
Hrm, I somehow overlooked the CPPFLAGS bit. Is it necessary? That wasn't changed for x86_64 and having not changed it for UML, it doesn't appear to have prevented the build from working on both x86_64 and i386 SUBARCHs here.

Quoted 5 lines

Quoted 5 lines
It shouldn't go in the general CPPFLAGS indeed. I think that -m64 in the preprocessor command used to build vmlinux.lds.S would be cleaner than #undef i386... test it by preprocessing by hand and report, I'll code the CPPFLAGS_vmlinux.lds.S = -m64 assignment (if it is exactly this way) if it works.

An incremental patch for Blaisorblade's idea follows. It builds successfully here.

---

On top of the previous biarch changes for UML, this makes the preprocessor changes a bit cleaner. Specify the 64-bit build in CPPFLAGS on the x86_64 SUBARCH, rather than #undef'ing i386. Compile-tested with i386 and x86_64 SUBARCHs.

Signed-off-by Nishanth Aravamudan <[email protected]>

arch/um/kernel/vmlinux.lds.S +0 -2

diff -urpN 2.6.17-dev2/arch/um/kernel/vmlinux.lds.S 2.6.17-dev/arch/um/kernel/vmlinux.lds.S
@@ -1,6 +1,4 @@
 #include <linux/config.h>
-/* in case the preprocessor is a 32bit one */
-#undef i386
 #ifdef CONFIG_LD_SCRIPT_STATIC
 #include "uml.lds.S"
 #else

arch/um/Makefile-x86_64 +1 -0

diff -urpN 2.6.17-dev2/arch/um/Makefile-x86_64 2.6.17-dev/arch/um/Makefile-x86_64
@@ -11,6 +11,7 @@ USER_CFLAGS += -fno-builtin -m64
 CHECKFLAGS  += -m64
 AFLAGS += -m64
 LDFLAGS += -m elf_x86_64
+CPPFLAGS += -m64
 
 ELF_ARCH := i386:x86-64
 ELF_FORMAT := elf64-x86-64

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2006-07-07 00:52 UTC #7 lore raw

Quoted 2 lines · Nishanth Aravamudan

An incremental patch for Blaisorblade's idea follows. It builds successfully here.

OK, that's in my tree, and I'll be sending it Linus-wards.

Jeff

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Paolo Giarrusso

2006-06-30 00:29 UTC #8 lore raw

In reply to Nishanth Aravamudan

Nishanth Aravamudan <[email protected]> ha scritto:

Quoted 7 lines · Blaisorblade

Just for clarity's sake, the reason the #undef is there, as far as I can
tell, is otherwise the preprocessor (I'm assuming) goes and makes the
output specification as 1:x86_64 instead of i386:x86_64.

I can confirm this is also what I understood.

Quoted 7 lines

I removed the #undef i386 from vmlinux.ld.S and added a
CPPFLAGS += -m64
to arch/um/Makefile-x86_64
The build completed fine here.

Yep, that's ok too (and shouldn't hurt for the rest - we'll get -m64 twice for .c files but it shouldn't be a problem; I thought to make it specific it only for vmlinux.lds.S to avoid the duplication).

Quoted 3 lines

I wonder if a patch against x86_64 to remove the #undef there should
also be applied? I'll take a look.

Probably it can, and IMHO it's cleaner. For me the patch is now perfect; Jeff please update the one in -mm.

Quoted 2 lines

Thanks,
Nish

Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2006-06-30 01:05 UTC #9 lore raw

Quoted 2 lines · Paolo Giarrusso

Probably it can, and IMHO it's cleaner. For me the patch is now perfect; Jeff please update the one in -mm.

Yeah, I'll send an update.

Jeff

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2006-06-28 02:11 UTC #10 lore raw

In reply to Nishanth Aravamudan

Quoted 5 lines · Nishanth Aravamudan

After discovering SUBARCH, I rebuilt my tree as an i386 UML and it successfully completed with this patch. If someone could test a native i386 build as well, just to be sure?
Updated patch follows.

How updated? I don't see any difference except for the new comment, which I fail to see fixing anything :-)

Jeff

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-28 02:54 UTC #11 lore raw

Quoted 9 lines · Jeff Dike

Quoted 5 lines · Nishanth Aravamudan
After discovering SUBARCH, I rebuilt my tree as an i386 UML and it successfully completed with this patch. If someone could test a native i386 build as well, just to be sure?
Updated patch follows.
How updated? I don't see any difference except for the new comment, which I fail to see fixing anything :-)

I added the comment that Blaisorblade asked for, that's it.

I didn't realize anything needed to be fixed? Removing the #undef causes the build to fail, so it's necessary, hence the comment. If you'd prefer a more verbose comment to that effect, I can do that, I guess.

Did I miss something?

Thanks,
Nish

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Jeff Dike

2006-06-28 03:43 UTC #12 lore raw

Quoted 1 line · Nishanth Aravamudan

Did I miss something?

Nope, I misread your mail. You described a problem (which had been fixed in the original patch), followed by "updated patch here", leading me to believe there was something fixed in it.

nevermind...

Jeff

Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Nishanth Aravamudan

author

2006-06-28 03:50 UTC #13 lore raw

Quoted 8 lines · Jeff Dike

Quoted 1 line · Nishanth Aravamudan
Did I miss something?
Nope, I misread your mail. You described a problem (which had been fixed in the original patch), followed by "updated patch here", leading me to believe there was something fixed in it.
nevermind...

Ah, sorry about that :)

Thanks,
Nish

Signature · 11 lines

Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
User-mode-linux-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel