pciehp borkage.
My head hurts..
drivers/pci/pcie/Kconfig ..
config HOTPLUG_PCI_PCIE
tristate "PCI Express Hotplug driver"
depends on HOTPLUG_PCI && PCIEPORTBUS && (BROKEN || ACPI)
but drivers/pci/hotplug/Makefile has..
pciehp-objs := pciehp_core.o \
pciehp_ctrl.o \
pciehp_pci.o \
pciehp_hpc.oSo it gets built regardless of the option, which leaves ppc (among others) totally busted..
In file included from include/acpi/platform/acenv.h:140,
from include/acpi/acpi.h:54,
from drivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/platform/aclinux.h:59:22: error: asm/acpi.h: No such file or directory In file included from include/acpi/acpi.h:55,
from drivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/actypes.h:129: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64' include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64' make[3]: *** [drivers/pci/hotplug/pciehp_hpc.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
Should that Makefile be more along the lines of..
pciehp-$(CONFIG_PCI_PCIE) := pciehp_core.o \
pciehp_ctrl.o \
pciehp_pci.o \
pciehp_hpc.operhaps ?
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 12 lines · Dave Jones
My head hurts..
drivers/pci/pcie/Kconfig..config
HOTPLUG_PCI_PCIE
tristate "PCI Express Hotplug driver"
depends onHOTPLUG_PCI&& PCIEPORTBUS && (BROKEN || ACPI)but
drivers/pci/hotplug/Makefilehas..
Quoted 7 lines
pciehp-objs := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.oSo it gets built regardless of the option, which leaves ppc (among others) totally busted..
Yes, this driver does have issues on ppc, see the archives for Anton trying to fix it up to get it to build. But as ppc currently doesn't _have_ pci express hotplug hardware it really doesn't matter much :)
Quoted 13 lines
In file included from
include/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/platform/aclinux.h:59:22: error:asm/acpi.h: No such file or directory In file included frominclude/acpi/acpi.h:55,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/actypes.h:129: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64'include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64' make[3]: *** [drivers/pci/hotplug/pciehp_hpc.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2
Quoted 8 lines
Should that
Makefilebe more along the lines of..pciehp-$(CONFIG_PCI_PCIE) := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.operhaps ?
No, look up a bit higher:
obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o
which will build pciehp or not. Just don't enable the option for now on ppc please. Until people sanitize the ACPI headers for non-acpi arches (which is currently underway...)
thanks,
greg k-h
Quoted 45 lines · Greg KH
Quoted 12 lines · Dave Jones
My head hurts..
drivers/pci/pcie/Kconfig..config
HOTPLUG_PCI_PCIE
tristate "PCI Express Hotplug driver"
depends onHOTPLUG_PCI&& PCIEPORTBUS && (BROKEN || ACPI)but
drivers/pci/hotplug/Makefilehas..Quoted 7 lines
pciehp-objs := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.oSo it gets built regardless of the option, which leaves ppc (among others) totally busted..
Yes, this driver does have issues on ppc, see the archives for Anton trying to fix it up to get it to build. But as ppc currently doesn't _have_ pci express hotplug hardware it really doesn't matter much :)
Quoted 20 lines
In file included from
include/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/platform/aclinux.h:59:22: error:asm/acpi.h: No such file or directory In file included frominclude/acpi/acpi.h:55,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/actypes.h:129: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'UINT64'include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'INT64' make[3]: *** [drivers/pci/hotplug/pciehp_hpc.o] Error 1
make[2]: *** [drivers/pci/hotplug] Error 2
make[1]: *** [drivers/pci] Error 2Should that
Makefilebe more along the lines of..pciehp-$(CONFIG_PCI_PCIE) := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.o
Quoted 8 lines
Quoted 1 line
perhaps ?
No, look up a bit higher:
obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.owhich will build pciehp or not. Just don't enable the option for now on ppc please. Until people sanitize the ACPI headers for non-acpi arches (which is currently underway...)
Would it be sane to make the Kconfig refuse to enable the option for archs that this is known to be broken on?
josh
Quoted 55 lines · Josh Boyer
Quoted 54 lines · Greg KH
Quoted 10 lines · Dave Jones
My head hurts..
drivers/pci/pcie/Kconfig..config
HOTPLUG_PCI_PCIE
tristate "PCI Express Hotplug driver"
depends onHOTPLUG_PCI&& PCIEPORTBUS && (BROKEN || ACPI)Quoted 8 lines
but
drivers/pci/hotplug/Makefilehas..pciehp-objs := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.oSo it gets built regardless of the option, which leaves ppc (among
others)
Quoted 1 line
totally busted..
Yes, this driver does have issues on ppc, see the archives for Anton trying to fix it up to get it to build. But as ppc currently doesn't _have_ pci express hotplug hardware it really doesn't matter much :)
Quoted 4 lines
In file included from
include/acpi/platform/acenv.h:140,
frominclude/acpi/acpi.h:54,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/platform/aclinux.h:59:22: error:asm/acpi.h: No such fileor directory
Quoted 3 lines
In file included from
include/acpi/acpi.h:55,
fromdrivers/pci/hotplug/pciehp_hpc.c:41:include/acpi/actypes.h:129: error: expected '=', ',', ';', 'asm' or'
__attribute__' before 'UINT64'Quoted 1 line
include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or'
__attribute__' before 'INT64'Quoted 5 lines
make[3]: *** [
drivers/pci/hotplug/pciehp_hpc.o] Error 1 make[2]: *** [drivers/pci/hotplug] Error 2 make[1]: *** [drivers/pci] Error 2Quoted 8 lines
Should that
Makefilebe more along the lines of..pciehp-$(CONFIG_PCI_PCIE) := pciehp_core.o \ pciehp_ctrl.o \ pciehp_pci.o \ pciehp_hpc.operhaps ?
No, look up a bit higher:
obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o
Quoted 6 lines
Quoted 3 lines
which will build pciehp or not. Just don't enable the option for now on ppc please. Until people sanitize the ACPI headers for non-acpi arches (which is currently underway...)
Would it be sane to make the
Kconfigrefuse to enable the option for archs that this is known to be broken on?
Sure, no objection from me there.
thanks,
greg k-h