Skip to contentSkip to conversation

microcode update driver rewrite - takes 2

PATCH Chuck Ebbert 1 participant 1 message Jun 27, 2006

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Review

Quoted 4 lines · Shaohua Li

This is the rewrite of microcode update driver. Changes:

(quoted diff) +2 -0
+             printk(KERN_ERR "microcode: error! Bad data in microcode "
+                             "data file\n");

I counted five of these "generic" error messages. I know the original driver had this problem too because I hit it and couldn't tell where the message came from.

Could you change these messages so they're unique and they describe the actual problem better? E.g. "data too large for user buffer" etc.?

Signature · 2 lines
Chuck
 "You can't read a newspaper if you can't read."  --George W. Bush