Skip to contentSkip to conversation

Process events biarch bug: Intro

RFC PATCH In review Matt Helsley 3 participants 5 messages Jun 27, 2006 – Jun 28, 2006

lore
Share & tools
lore
#0 lore raw

cover Process events biarch bug: Intro

The events sent by Process Events from a 64-bit kernel are not binary compatible with what a 32-bit userspace program would expect to recieve because the timespec struct (used to send a timestamp) is not the same. This means that fields stored after the timestamp are offset and programs that don't take this into account break under these circumstances.

This is a problem for 32-bit userspace programs running with 64-bit kernels on ppc64, s390, x86-64.. any "biarch" system.

This series:

1 - Gives a name to the union of the process events structure so it may be used
to work around the problem from userspace.
2 - Comments on the bug and describes a userspace workaround in
Documentation/connector/process_events.txt
3 - Implements a second connector interface without the problem
(Removing the old interface or changing the definition would break
binary compatibility)

Compiled, booted, and lightly tested.

Comments or suggestions on alternate approaches would be appreciated.

Cheers,
-Matt Helsley

#1 lore raw
Quoted 11 lines · Matt Helsley

The events sent by Process Events from a 64-bit kernel are not binary compatible with what a 32-bit userspace program would expect to recieve because the timespec struct (used to send a timestamp) is not the same. This means that fields stored after the timestamp are offset and programs that don't take this into account break under these circumstances.

This is a problem for 32-bit userspace programs running with 64-bit kernels on ppc64, s390, x86-64.. any "biarch" system.

This series:

Quoted 7 lines

1 - Gives a name to the union of the process events structure so it may be used
to work around the problem from userspace.
2 - Comments on the bug and describes a userspace workaround in
Documentation/connector/process_events.txt
3 - Implements a second connector interface without the problem
(Removing the old interface or changing the definition would break
binary compatibility)

If you are sure binary compatibility on this stage of process
notification connector is really major issue, then I agree that above is correct, otherwise I would recommend to just replace broken code with fixed size objects.

Btw, __u64 is not the best choice for some arches too due to it's alignment (64bit code requires u64 to be aligned to 64 bit, while 32bit code will only align it to 32 bits), so you will need attribute ((aligned(8)))) for your own ___u64.

Signature · 1 line
	Evgeniy Polyakov
#2 lore raw
Quoted 20 lines · Evgeniy Polyakov
Quoted 11 lines · Matt Helsley

The events sent by Process Events from a 64-bit kernel are not binary compatible with what a 32-bit userspace program would expect to recieve because the timespec struct (used to send a timestamp) is not the same. This means that fields stored after the timestamp are offset and programs that don't take this into account break under these circumstances.

This is a problem for 32-bit userspace programs running with 64-bit kernels on ppc64, s390, x86-64.. any "biarch" system.

This series:

Quoted 7 lines

1 - Gives a name to the union of the process events structure so it may be used
to work around the problem from userspace.
2 - Comments on the bug and describes a userspace workaround in
Documentation/connector/process_events.txt
3 - Implements a second connector interface without the problem
(Removing the old interface or changing the definition would break
binary compatibility)

Quoted 3 lines

If you are sure binary compatibility on this stage of process
notification connector is really major issue, then I agree that above is correct, otherwise I would recommend to just replace broken code with fixed size objects.

It's not clear whether event binary compatibility is a major issue. I
chose to assume it was and presented the best option (that I could think of) for preserving binary compatibility.

Quoted 4 lines

Btw, __u64 is not the best choice for some arches too due to it's alignment (64bit code requires u64 to be aligned to 64 bit, while 32bit code will only align it to 32 bits), so you will need attribute ((aligned(8)))) for your own ___u64.

Fixing the alignment would be a good idea. Though setting it to 8 would
introduce 4 unused bytes at the end of the structure.

Cheers,
-Matt Helsley

#3 lore raw
Quoted 7 lines · Matt Helsley
Quoted 4 lines

Btw, __u64 is not the best choice for some arches too due to it's alignment (64bit code requires u64 to be aligned to 64 bit, while 32bit code will only align it to 32 bits), so you will need attribute ((aligned(8)))) for your own ___u64.

Fixing the alignment would be a good idea. Though setting it to 8 would
introduce 4 unused bytes at the end of the structure.

Otherwise your code will not work, although u64 is supposed to be fixed size, due to it's alignment problems it can not be used as is. Split timestamp into two 32bit values and everything will be ok.

Quoted 2 lines

Cheers,
-Matt Helsley

Signature · 1 line
	Evgeniy Polyakov
#4 lore raw
In reply to Matt Helsley
Quoted 9 lines · Matt Helsley

The events sent by Process Events from a 64-bit kernel are not binary compatible with what a 32-bit userspace program would expect to recieve because the timespec struct (used to send a timestamp) is not the same. This means that fields stored after the timestamp are offset and programs that don't take this into account break under these circumstances.

This is a problem for 32-bit userspace programs running with 64-bit kernels on ppc64, s390, x86-64.. any "biarch" system.

Quoted 6 lines

This series:

1 - Gives a name to the union of the process events structure so it may be used
to work around the problem from userspace.
2 - Comments on the bug and describes a userspace workaround in
Documentation/connector/process_events.txt

Above two options need the user space program to workaround the issue, while assuming that the size of the data structure will never change (if it ever changes, you break compatibility), which IMO is not very appealing.

Quoted 3 lines

3 - Implements a second connector interface without the problem
(Removing the old interface or changing the definition would break
binary compatibility)

I think this is a better option if we want to fix the problem while maintaining compatibility.

Quoted 14 lines

Compiled, booted, and lightly tested.

Comments or suggestions on alternate approaches would be appreciated.

Cheers,
-Matt Helsley

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 4 lines
----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - [email protected]   |      .......you may get it.
----------------------------------------------------------------------