Skip to contentSkip to conversation

Restore set_nmi_callback export on x86_64

PATCH In review Jean Delvare 2 participants 2 messages Jun 27, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Restore set_nmi_callback export on x86_64

Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular oprofile (amongst others I suspect) on x86_64 by killing the exports of set_nmi_callback and unset_nmi_callback. Let's restore the exports next to the functions as is prefered now.

---
 arch/x86_64/kernel/nmi.c |    2 ++
 1 files changed, 2 insertions(+)
arch/x86_64/kernel/nmi.c +2 -0
@@ -607,11 +607,13 @@
 	vmalloc_sync_all();
 	rcu_assign_pointer(nmi_callback, callback);
 }
+EXPORT_SYMBOL_GPL(set_nmi_callback);
 
 void unset_nmi_callback(void)
 {
 	nmi_callback = dummy_nmi_callback;
 }
+EXPORT_SYMBOL_GPL(unset_nmi_callback);
 
 #ifdef CONFIG_SYSCTL
 
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 4 lines · Jean Delvare

Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular oprofile (amongst others I suspect) on x86_64 by killing the exports of set_nmi_callback and unset_nmi_callback. Let's restore the exports next to the functions as is prefered now.

Hmm yes this happened because I got unsubmitted patches that remove set_nmi_callback/unset_nmi_callback

But for 2.6.18 the patch is good, thanks.

-Andi

Quoted 25 lines
---
 arch/x86_64/kernel/nmi.c |    2 ++
 1 files changed, 2 insertions(+)
arch/x86_64/kernel/nmi.c +2 -0
@@ -607,11 +607,13 @@
 	vmalloc_sync_all();
 	rcu_assign_pointer(nmi_callback, callback);
 }
+EXPORT_SYMBOL_GPL(set_nmi_callback);
 
 void unset_nmi_callback(void)
 {
 	nmi_callback = dummy_nmi_callback;
 }
+EXPORT_SYMBOL_GPL(unset_nmi_callback);
 
 #ifdef CONFIG_SYSCTL