Skip to contentSkip to conversation

powerpc: U4 DART improvements

PATCH New Olof Johansson 1 participant 1 message Jun 28, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: U4 DART improvements

Better late than never...

Respin based on previous comment. Only remaining issue last time was an extra mb() that I've taken out.

---

Implement single-entry TLB invalidations in the U4 DART.

Simple benchmarking with loopback flood pings of various sizes show that the previous flush-all code will spend ~5% of the time in flush, while the new selective invalidations will spend about an order of magnitude less in the same code path.

This could possibly mean that invalidations larger than, say, 16 entries would better be handled in bulk, but until we have a workload that actually shows problems or bottlenecks let's keep doing single invalidations at all mapping sizes.

arch/powerpc/sysdev/dart.h +5 -1
Index: linux-2.6/arch/powerpc/sysdev/dart.h
===================================================================
@@ -47,8 +47,12 @@
 /* U4 registers */
 #define DART_BASE_U4_BASE_MASK	0xffffff
 #define DART_BASE_U4_BASE_SHIFT	0
-#define DART_CNTL_U4_FLUSHTLB	0x20000000
 #define DART_CNTL_U4_ENABLE	0x80000000
+#define DART_CNTL_U4_IONE	0x40000000
+#define DART_CNTL_U4_FLUSHTLB	0x20000000
+#define DART_CNTL_U4_IDLE	0x10000000
+#define DART_CNTL_U4_PAR_EN	0x08000000
+#define DART_CNTL_U4_IONE_MASK	0x07ffffff
 #define DART_SIZE_U4_SIZE_MASK	0x1fff
 #define DART_SIZE_U4_SIZE_SHIFT	0
 
arch/powerpc/sysdev/dart_iommu.c +43 -6

82 lines not on this page · raw message