Skip to contentSkip to conversation

minor optimizations to ondemand governor

PATCH In review Venkatesh Pallipadi 2 participants 2 messages Jun 28, 2006 – Jun 30, 2006

lore
Share & tools
lore
#0 lore raw

cover minor optimizations to ondemand governor

Patch series with optimizations to ondemand governor and some coding-style cleanups.

[PATCH 1/4] minor optimizations to ondemand governor ondemand_remove_slowdown_06.patch
Removes the slowdown option from ondemand governor. This simplifies code in periodic sampling a lot and reduces the path length in dbs_check_cpu by half.

[PATCH 2/4] minor optimizations to ondemand governor queue_delayed_work_on_02.patch
Add a new interface to workqueue to enable scheduling work on a particular CPU.

[PATCH 3/4] minor optimizations to ondemand governor ondemand_percpu_06.patch
Use queue_delayed_work_on interface to make ondemand sampling percpu. This also removes the mutex in sampling path.

[PATCH 4/4] minor optimizations to ondemand governor ondemand_misc_cleanups_06.patch
Misc. cleanups to ondemand from coding-style perspective.

Thanks,
Venki

#1 lore raw
Quoted 14 lines · Venkatesh Pallipadi

Patch series with optimizations to ondemand governor and some coding-style cleanups.

[PATCH 1/4] minor optimizations to ondemand governor ondemand_remove_slowdown_06.patch
Removes the slowdown option from ondemand governor. This simplifies code in periodic sampling a lot and reduces the path length in dbs_check_cpu by half.

[PATCH 2/4] minor optimizations to ondemand governor queue_delayed_work_on_02.patch
Add a new interface to workqueue to enable scheduling work on a particular CPU.

Quoted 8 lines

[PATCH 3/4] minor optimizations to ondemand governor ondemand_percpu_06.patch
Use queue_delayed_work_on interface to make ondemand sampling percpu. This also removes the mutex in sampling path.

[PATCH 4/4] minor optimizations to ondemand governor ondemand_misc_cleanups_06.patch
Misc. cleanups to ondemand from coding-style perspective.

Minor annoyance: Give the Subject: lines some more context, as git uses them for short-log generation, and

[CPUFREQ] Remove the slowdown option from ondemand governor
[CPUFREQ] Add a new interface to workqueue to enable scheduling work on a particular CPU.

looks a bit more informative than

[CPUFREQ] [1/4] minor optimizations to ondemand governor [CPUFREQ] [2/4] minor optimizations to ondemand governor etc...

(I'll fix these up this time around, as they don't look like
they'll need much more work, and I need to make some minor edits anyway)

Other minor review comments follow:

Dave

Signature · 1 line
http://www.codemonkey.org.uk