AGP_AMD64 must depend on PCI
PATCH 1/1 AGP_AMD64 must depend on PCI
This patch fixes the following compile error:
<-- snip -->
...
CC arch/i386/kernel/../../x86_64/kernel/k8.oarch/i386/kernel/../../x86_64/kernel/k8.c: In function ‘next_k8_northbridge’:arch/i386/kernel/../../x86_64/kernel/k8.c:34: error: implicit declaration of function ‘pci_match_id’
<-- snip -->
drivers/char/agp/Kconfig renamed from drivers/char/agp/Kconfig.old +1 -1
@@ -56,7 +56,7 @@ config AGP_AMD64 tristate "AMD Opteron/Athlon64 on-CPU GART support" if !IOMMU - depends on AGP && X86 + depends on AGP && PCI && X86 default y if IOMMU help This option gives you AGP support for the GLX component of
Quoted 16 lines · Adrian Bunk
This patch fixes the following compile error:
<-- snip -->
...
CCarch/i386/kernel/../../x86_64/kernel/k8.oarch/i386/kernel/../../x86_64/kernel/k8.c: In function ‘next_k8_northbridge’:arch/i386/kernel/../../x86_64/kernel/k8.c:34: error: implicit declaration of function ‘pci_match_id’<-- snip -->
Signed-off-by Adrian Bunk <[email protected]>
drivers/char/agp/Kconfig line 62
Quoted 8 lines
drivers/char/agp/Kconfig renamed from drivers/char/agp/Kconfig.old +1
-1@@ -56,7 +56,7 @@ config AGP_AMD64 tristate "AMD Opteron/Athlon64 on-CPU GART support" if !IOMMU - depends on AGP && X86 + depends on AGP && PCI && X86 default y if IOMMU help This option gives you AGP support for the GLX component of
What makes this driver special ? The other AGP drivers also use various PCI functions, and don't have a similar dependancy.
Adding depends on PCI to 'AGP' may make more sense than adding it to the individual drivers, especially as the core AGP code also
uses the pci layer. As AGP is just a bastardised variant of PCI
anyway, adding an explicit dependancy should be sane on all archs, even alpha with its wierdo 'faked pci bridge'.
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 18 lines · Dave Jones
Quoted 17 lines · Adrian Bunk
This patch fixes the following compile error:
<-- snip -->
...
CCarch/i386/kernel/../../x86_64/kernel/k8.oarch/i386/kernel/../../x86_64/kernel/k8.c: In function ‘next_k8_northbridge’:arch/i386/kernel/../../x86_64/kernel/k8.c:34: error: implicit declaration of function ‘pci_match_id’<-- snip -->
Signed-off-by Adrian Bunk <[email protected]>drivers/char/agp/Kconfig renamed from drivers/char/agp/Kconfig.old +0
-0@@ -56,7 +56,7 @@
Quoted 10 lines
drivers/char/agp/Kconfig line 62
Quoted 7 lines
drivers/char/agp/Kconfig renamed from drivers/char/agp/Kconfig.old +1
-1config AGP_AMD64 tristate "AMD Opteron/Athlon64 on-CPU GART support" if !IOMMU - depends on AGP && X86 + depends on AGP && PCI && X86 default y if IOMMU help This option gives you AGP support for the GLX component ofWhat makes this driver special ? The other AGP drivers also use various PCI functions, and don't have a similar dependancy.
The usage of pci_match_id() was the only case where an AGP driver didn't compile with CONFIG_PCI=n (the other used PCI functions have dummies for CONFIG_PCI=n).
Quoted 5 lines
Adding depends on PCI to 'AGP' may make more sense than adding it to the individual drivers, especially as the core AGP code also
uses the pci layer. As AGP is just a bastardised variant of PCI
anyway, adding an explicit dependancy should be sane on all archs, even alpha with its wierdo 'faked pci bridge'.
Fine with me.
Quoted 1 line
Dave
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed