tg3: Add tg3_netif_stop() in vlan functions
Subsystems (2)
PATCH 1/5 tg3: Add tg3_netif_stop() in vlan functions
Add tg3_netif_stop() when changing the vlgrp (vlan group) pointer. It is necessary to quiesce the device before changing that pointer.
Signed-off-by Michael Chan <[email protected]>
drivers/net/tg3.c +12 -0
@@ -8738,6 +8738,9 @@ static void tg3_vlan_rx_register(struct {struct tg3 *tp =netdev_priv (dev); +if (netif_running (dev)) +tg3_netif_stop (tp); +tg3_full_lock (tp,0 ); tp->vlgrp = grp;
@@ -8746,16 +8749,25 @@ static void tg3_vlan_rx_register(struct__tg3_set_rx_mode (dev);tg3_full_unlock (tp); + +if (netif_running (dev)) + tg3_netif_start(tp); }static void tg3_vlan_rx_kill_vid (struct net_device *dev,unsigned short vid) {struct tg3 *tp =netdev_priv (dev); +if (netif_running (dev)) +tg3_netif_stop (tp); +tg3_full_lock (tp,0 );if (tp->vlgrp) tp->vlgrp->vlan_devices[vid] =NULL ;tg3_full_unlock (tp); + +if (netif_running (dev)) +tg3_netif_start (tp); }#endif
From: "Michael Chan" <[email protected]>
Date: Thu, 29 Jun 2006 18:29:06 -0700
Quoted 4 lines
Add
tg3_netif_stop()when changing the vlgrp (vlan group) pointer. It is necessary to quiesce the device before changing that pointer.Signed-off-by Michael Chan <[email protected]>
Good catch.
Applied, thanks a lot Michael.