Skip to contentSkip to conversation

2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

DISCUSSION Gregoire Favre 4 participants 5 messages Jun 29, 2006

lore
Share & tools
lore
#0 lore raw

Hello,

just tried to compil 2.6.17-mm4 under amd64 and it fails with :

  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1

arch/x86_64/kernel/built-in.o: In function `module_arch_cleanup':
(.text.module_arch_cleanup+0x1): undefined reference to alternatives_smp_module_del' arch/x86_64/kernel/built-in.o: In function module_finalize':
(.text.module_finalize+0xe8): undefined reference to `alternatives_smp_module_add'
make: *** [.tmp_vmlinux1] Error 1

Please CC to me if some more info are needed as I am not on this list.

Signature · 1 line
Grégoire FAVRE  http://gregoire.favre.googlepages.com  http://www.gnupg.org
#1 lore raw
Quoted 12 lines · Gregoire Favre

Hello,

just tried to compil 2.6.17-mm4 under amd64 and it fails with :

  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
Quoted 7 lines

arch/x86_64/kernel/built-in.o: In function `module_arch_cleanup':
(.text.module_arch_cleanup+0x1): undefined reference to alternatives_smp_module_del' arch/x86_64/kernel/built-in.o: In function module_finalize':
(.text.module_finalize+0xe8): undefined reference to `alternatives_smp_module_add'
make: *** [.tmp_vmlinux1] Error 1

Thanks. Reverting ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm4/broken-out/x86-dont-print-out-smp-info-on-up-kernels.patch will fix it.

<looks at davej>

That patch is pretty yuk anyway

void module_arch_cleanup(struct module *mod)
{
+#ifdef CONFIG_SMP

	alternatives_smp_module_del(mod);

+#endif
}

Should be a stub in a header file, which would fix this problem too.

#2 lore raw
Quoted 4 lines · Andrew Morton

<looks at davej>

That patch is pretty yuk anyway

Quoted 8 lines

void module_arch_cleanup(struct module *mod)
{
+#ifdef CONFIG_SMP

	alternatives_smp_module_del(mod);

+#endif
}

Should be a stub in a header file, which would fix this problem too.

Gerd Hoffmann already did this and I suppose it's in some upstream tree somewhere:

http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2

Rene.

#3 lore raw
Quoted 14 lines · Rene Herman
Quoted 11 lines · Andrew Morton

<looks at davej>

That patch is pretty yuk anyway

void module_arch_cleanup(struct module *mod)
{
+#ifdef CONFIG_SMP

	alternatives_smp_module_del(mod);

+#endif
}

Quoted 4 lines
Quoted 1 line

Should be a stub in a header file, which would fix this problem too.

Gerd Hoffmann already did this and I suppose it's in some upstream tree somewhere:

I'd say it got lost.

Quoted 2 lines

http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2

<snarf>

Thanks.

#4 lore raw
Quoted 7 lines · Andrew Morton
Quoted 4 lines
Quoted 1 line

Should be a stub in a header file, which would fix this problem too.

Gerd Hoffmann already did this and I suppose it's in some upstream tree somewhere:

I'd say it got lost.

Quoted 1 line

http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2

Ha, I was just reconstructing the exact same patch.

Quoted 1 line

<snarf>

Yay!

Dave

Signature · 1 line
http://www.codemonkey.org.uk