fix ISTALLION=y
PATCH 1/1 fix ISTALLION=y
This patch fixes the following problems:
<-- snip -->
...
CC drivers/char/istallion.odrivers/char/istallion.c: In function ‘stli_initbrds’:drivers/char/istallion.c:4150: error: implicit declaration of function ‘stli_parsebrd’ drivers/char/istallion.c:4150: error: ‘stli_brdsp’ undeclared (first use in this function) drivers/char/istallion.c:4150: error: (Each undeclared identifier is reported only once drivers/char/istallion.c:4150: error: for each function it appears in.) drivers/char/istallion.c:4164: error: implicit declaration of function ‘stli_argbrds’
<-- snip -->
While I was at it, I also removed the #ifdef MODULE around the initialation code to allow it to perhaps work when built into the kernel and made a needlessly global function static.
---
drivers/char/istallion.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-)
drivers/char/istallion.c renamed from drivers/char/istallion.c.old +2 -15
@@ -283,7 +283,6 @@/*****************************************************************************/ -#ifdef MODULE /* * Define some string labels for arguments passed from the module * load line. These allow for easy board definitions, and easy
@@ -382,8 +381,6 @@module_param_array (board3, charp,NULL ,0 );MODULE_PARM_DESC (board3,"Board 3 config -> name[,ioaddr[,memaddr]" ); -#endif -/* * Set up a default memory address table for EISA board probing. * The default addresses are all bellow 1Mbyte, which has to be the
@@ -644,14 +641,8 @@* Prototype all functions in this driver! */ -#ifdef MODULE -static void stli_argbrds (void );static int stli_parsebrd (stlconf_t *confp,char **argp); - -static unsigned long stli_atol (char *str); -#endif - -int stli_init (void ); +static int stli_init (void );static int stli_open (struct tty_struct *tty,struct file *filp);static void stli_close (struct tty_struct *tty,struct file *filp);static int stli_write (struct tty_struct *tty,const unsigned char *buf,int count);
@@ -787,8 +778,6 @@static struct class *istallion_class; -#ifdef MODULE -/* * Loadable module initialization stuff. */
@@ -958,8 +947,6 @@return (1 ); } -#endif -/*****************************************************************************/ static int stli_open (struct tty_struct *tty,struct file *filp)
@@ -4698,7 +4685,7 @@/*****************************************************************************/ -int __init stli_init (void ) +static int __init stli_init (void ) {int i;printk (KERN_INFO "%s: version %s\n" , stli_drvtitle, stli_drvversion);