Skip to contentSkip to conversation

make net/core/skbuff.c:skb_release_data() static

PATCH In review Adrian Bunk 2 participants 4 messages Jun 23, 2006 – Jun 29, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make net/core/skbuff.c:skb_release_data() static

skb_release_data() no longer has any users in other files.

---

 include/linux/skbuff.h |    2 --
 net/core/skbuff.c      |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
include/linux/skbuff.h renamed from include/linux/skbuff.h.old +0 -2
@@ -1289,8 +1289,6 @@
 extern void	       skb_split(struct sk_buff *skb,
 				 struct sk_buff *skb1, const u32 len);
 
-extern void	       skb_release_data(struct sk_buff *skb);
-
 static inline void *skb_header_pointer(const struct sk_buff *skb, int offset,
 				       int len, void *buffer)
 {
net/core/skbuff.c renamed from net/core/skbuff.c.old +1 -1
@@ -292,7 +292,7 @@
 		skb_get(list);
 }
 
-void skb_release_data(struct sk_buff *skb)
+static void skb_release_data(struct sk_buff *skb)
 {
 	if (!skb->cloned ||
 	    !atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
maintainer
#1 lore raw

From: Adrian Bunk <[email protected]>
Date: Fri, 23 Jun 2006 12:56:23 +0200

Quoted 3 lines

skb_release_data() no longer has any users in other files.

If you are going to do this, you need to remove the reference in arch/x86_64/kernel/functionlist too.

Thanks.

#2 lore raw

PATCH 1/1 make net/core/skbuff.c:skb_release_data() static

Quoted 11 lines · David Miller

From: Adrian Bunk <[email protected]>
Date: Fri, 23 Jun 2006 12:56:23 +0200

Quoted 3 lines

skb_release_data() no longer has any users in other files.

If you are going to do this, you need to remove the reference in arch/x86_64/kernel/functionlist too.

Thanks.

Corrected patch below.

cu
Adrian

<-- snip -->

skb_release_data() no longer has any users in other files.

---

 arch/x86_64/kernel/functionlist |    1 -
 include/linux/skbuff.h          |    1 -
 net/core/skbuff.c               |    2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)
include/linux/skbuff.h renamed from include/linux/skbuff.h.old +0 -1
@@ -1301,7 +1301,6 @@
 extern void	       skb_split(struct sk_buff *skb,
 				 struct sk_buff *skb1, const u32 len);
 
-extern void	       skb_release_data(struct sk_buff *skb);
 extern struct sk_buff *skb_segment(struct sk_buff *skb, int sg);
 
 static inline void *skb_header_pointer(const struct sk_buff *skb, int offset,
net/core/skbuff.c renamed from net/core/skbuff.c.old +1 -1
@@ -279,7 +279,7 @@
 		skb_get(list);
 }
 
-void skb_release_data(struct sk_buff *skb)
+static void skb_release_data(struct sk_buff *skb)
 {
 	if (!skb->cloned ||
 	    !atomic_sub_return(skb->nohdr ? (1 << SKB_DATAREF_SHIFT) + 1 : 1,
arch/x86_64/kernel/functionlist renamed from arch/x86_64/kernel/functionlist.old +0 -1
@@ -384,7 +384,6 @@
 *(.text.__end_that_request_first)
 *(.text.wake_up_bit)
 *(.text.unuse_mm)
-*(.text.skb_release_data)
 *(.text.shrink_icache_memory)
 *(.text.sched_balance_self)
 *(.text.__pmd_alloc)
maintainer Applied
#3 lore raw

From: Adrian Bunk <[email protected]>
Date: Thu, 29 Jun 2006 21:20:20 +0200

Quoted 6 lines · David Miller
Quoted 5 lines

From: Adrian Bunk <[email protected]>
Date: Fri, 23 Jun 2006 12:56:23 +0200

Quoted 2 lines

skb_release_data() no longer has any users in other files.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

If you are going to do this, you need to remove the reference in arch/x86_64/kernel/functionlist too.

Thanks.

Corrected patch below.

Applied, thanks.