Skip to contentSkip to conversation

mm/mmzone.c: EXPORT_UNUSED_SYMBOL

PATCH In review Adrian Bunk 2 participants 2 messages Jun 30, 2006 – Jul 1, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/mmzone.c: EXPORT_UNUSED_SYMBOL

This patch marks three unused exports as EXPORT_UNUSED_SYMBOL.

---

 mm/mmzone.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
mm/mmzone.c renamed from mm/mmzone.c.old +3 -3
@@ -15,7 +15,7 @@
 	return NODE_DATA(first_online_node);
 }
 
-EXPORT_SYMBOL(first_online_pgdat);
+EXPORT_UNUSED_SYMBOL(first_online_pgdat);  /*  June 2006  */
 
 struct pglist_data *next_online_pgdat(struct pglist_data *pgdat)
 {
@@ -25,7 +25,7 @@
 		return NULL;
 	return NODE_DATA(nid);
 }
-EXPORT_SYMBOL(next_online_pgdat);
+EXPORT_UNUSED_SYMBOL(next_online_pgdat);  /*  June 2006  */
 
 
 /*
@@ -46,5 +46,5 @@
 	}
 	return zone;
 }
-EXPORT_SYMBOL(next_zone);
+EXPORT_UNUSED_SYMBOL(next_zone);  /*  June 2006  */
 
#1 lore raw

mm/mmzone.c line 18

Quoted 2 lines · On Fri, 30 Jun 2006 13:32:48 +0200 Adrian Bunk <[email protected]> wrote:
mm/mmzone.c renamed from mm/mmzone.c.old +1 -1
-EXPORT_SYMBOL(first_online_pgdat);
+EXPORT_UNUSED_SYMBOL(first_online_pgdat);  /*  June 2006  */

for_each_zone() and for_each_online_pgdat() need this. So the export is an internal implementation detail to support those macros. Those macros are reasonable(ish) things to be doing from modules - could be that people are using for_each_zone() already.

mm/mmzone.c line 28

Quoted 2 lines
mm/mmzone.c renamed from mm/mmzone.c.old +1 -1
-EXPORT_SYMBOL(next_online_pgdat);
+EXPORT_UNUSED_SYMBOL(next_online_pgdat);  /*  June 2006  */

Ditto

mm/mmzone.c line 49

Quoted 3 lines
mm/mmzone.c renamed from mm/mmzone.c.old +1 -1
-EXPORT_SYMBOL(next_zone);
+EXPORT_UNUSED_SYMBOL(next_zone);  /*  June 2006  */

Tritto.

We could give it a whizz, but I'd expect that we'll end up dropping it. But then again, zones are fairly low-level things. Let's give it a try.