PNPACPI: support shareable interrupts
Subsystems (3)
PATCH 1/2 PNPACPI: support shareable interrupts
ACPI supplies a "shareable" indication, but PNPACPI ignores it. If a PNP device uses a shared interrupt, request_irq() fails because the PNP driver can't tell whether to supply SA_SHIRQ.
This patch allows PNP drivers to test
(pnp_irq_flags(dev, 0) & IORESOURCE_IRQ_SHAREABLE)
Signed-off-by Bjorn Helgaas <[email protected]>
include/linux/ioport.h +1 -0
@@ -55,6 +55,7 @@#define IORESOURCE_IRQ_LOWEDGE (1<<1)#define IORESOURCE_IRQ_HIGHLEVEL (1<<2)#define IORESOURCE_IRQ_LOWLEVEL (1<<3) +#define IORESOURCE_IRQ_SHAREABLE (1<<4)/* ISA PnP DMA specific bits (IORESOURCE_BITS) */ #define IORESOURCE_DMA_TYPE_MASK (3<<0)
drivers/pnp/pnpacpi/rsparser.c +8 -3
@@ -74,7 +74,7 @@static void pnpacpi_parse_allocated_irqresource (struct pnp_resource_table *res,u32 gsi, -int triggering,int polarity) +int triggering,int polarity,int shareable) {int i =0 ;int irq;
@@ -95,6 +95,9 @@return ; } +if (shareable) + res->irq_resource[i].flags |=IORESOURCE_IRQ_SHAREABLE ; + res->irq_resource[i].start = irq; res->irq_resource[i].end = irq;pcibios_penalize_isa_irq (irq,1 );
@@ -197,7 +200,8 @@pnpacpi_parse_allocated_irqresource (res_table, res->data.irq.interrupts[i], res->data.irq.triggering, - res->data.irq.polarity); + res->data.irq.polarity, + res->data.irq.sharable); }break ;
@@ -263,7 +267,8 @@pnpacpi_parse_allocated_irqresource (res_table, res->data.extended_irq.interrupts[i], res->data.extended_irq.triggering, - res->data.extended_irq.polarity); + res->data.extended_irq.polarity, + res->data.extended_irq.sharable); }break ;
drivers/pnp/pnpacpi/rsparser.c
Quoted 3 lines · Bjorn Helgaas
drivers/pnp/pnpacpi/rsparser.c +0
-0
pnpacpi confuses me. Who maintains it? Is it considered an APCI thing, or a PNP thing or a Bjorn thing?
Thanks.