Skip to contentSkip to conversation

SERIAL: allow shared 8250_pnp interrupts

PATCH In review Bjorn Helgaas 2 participants 2 messages Jun 30, 2006 – Jul 1, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 SERIAL: allow shared 8250_pnp interrupts

PNP devices can use shared interrupts, so check to see whether we'll need SA_SHIRQ for request_irq().

The builtin PDH UART on the HP rx8640 is an example of an ACPI/PNP device that uses a shareable level-triggered, active-low interrupt. The interrupt can be shared in very large I/O configurations or by artificially lowering IA64_DEF_LAST_DEVICE_VECTOR.

drivers/serial/8250_pnp.c +2 -0
Index: as3877/drivers/serial/8250_pnp.c
===================================================================
@@ -431,6 +431,8 @@
 #endif
 
 	port.flags |= UPF_SKIP_TEST | UPF_BOOT_AUTOCONF;
+	if (pnp_irq_flags(dev, 0) & IORESOURCE_IRQ_SHAREABLE)
+		port.flags |= UPF_SHARE_IRQ;
 	port.uartclk = 1843200;
 	port.dev = &dev->dev;
 
Acked-by on v1 2/2
#1 lore raw
Quoted 9 lines · Bjorn Helgaas

PNP devices can use shared interrupts, so check to see whether we'll need SA_SHIRQ for request_irq().

The builtin PDH UART on the HP rx8640 is an example of an ACPI/PNP device that uses a shareable level-triggered, active-low interrupt. The interrupt can be shared in very large I/O configurations or by artificially lowering IA64_DEF_LAST_DEVICE_VECTOR.

Quoted 13 lines

Index: as3877/drivers/serial/8250_pnp.c
===================================================================

drivers/serial/8250_pnp.c +2 -0
@@ -431,6 +431,8 @@
 #endif
 
 	port.flags |= UPF_SKIP_TEST | UPF_BOOT_AUTOCONF;
+	if (pnp_irq_flags(dev, 0) & IORESOURCE_IRQ_SHAREABLE)
+		port.flags |= UPF_SHARE_IRQ;
 	port.uartclk = 1843200;
 	port.dev = &dev->dev;
 
Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core