Skip to contentSkip to conversation

ACPI: Device [kobj-name] is not power manageable

DISCUSSION Randy.Dunlap 2 participants 2 messages Jul 1, 2006 1 message not in the archive ACPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 23 lines · On Fri, 30 Jun 2006 23:59:25 GMT Linux Kernel Mailing List wrote:

commit 64dedfb8fdbbc4fabb8c131e4b597cd4bc7f3881
tree 7ef0c5e0574bc94fe4d25bb5994b31938205e7cf
parent 9e7e2c047503db5a094ab30c7b4b8a5a0a324915
author Jae-hyeon Park <[email protected]> Tue, 27 Jun 2006 06:34:03 -0400 committer Len Brown <[email protected]> Tue, 27 Jun 2006 08:00:40 -0400

ACPI: Device [kobj-name] is not power manageable

print kobj name in this message.
lenb changed to use printk.

 drivers/acpi/bus.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/acpi/bus.c +0 -0
index 917bf23..f4a36d3 100644

drivers/acpi/bus.c int acpi_bus_set_power(acpi_handle handl

Quoted 10 lines
drivers/acpi/bus.c +2 -2
@@ -196,7 +196,8 @@ int acpi_bus_set_power(acpi_handle handl
 	/* Make sure this is a valid target state */
 
 	if (!device->flags.power_manageable) {
-		ACPI_INFO((AE_INFO, "Device is not power manageable"));
+		printk(KERN_DEBUG "Device `[%s]is not power manageable",
+				device->kobj.name);
 		return_VALUE(-ENODEV);
 	}
 	/*
-

Andrew, can you send Linus the typo correction patch for this?? or should I?

s/`//
s/]/] /

Hm, needs a \n too.

~Randy

#2 lore raw
Quoted 3 lines · Randy.Dunlap

Andrew, can you send Linus the typo correction patch for this?? or should I?

Is OK, I have a couple of post-acpi-merge fixlets queued which I'll be sending in the next batch.

drivers/acpi/acpi_memhotplug.c renamed from drivers/acpi/acpi_memhotplug.c~acpi-printk-fix +1 -1
diff -puN drivers/acpi/acpi_memhotplug.c~acpi-printk-fix drivers/acpi/acpi_memhotplug.c
@@ -248,7 +248,7 @@ static int acpi_memory_enable_device(str
 		num_enabled++;
 	}
 	if (!num_enabled) {
-		ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n"));
+		printk(KERN_ERR PREFIX "add_memory failed\n");
 		mem_device->state = MEMORY_INVALID_STATE;
 		return -EINVAL;
 	}

_

and

drivers/acpi/bus.c renamed from drivers/acpi/bus.c~acpi-identify-which-device-is-not-power-manageable +1 -1
@@ -192,7 +192,7 @@ int acpi_bus_set_power(acpi_handle handl
 	/* Make sure this is a valid target state */
 
 	if (!device->flags.power_manageable) {
-		printk(KERN_DEBUG "Device `[%s]is not power manageable",
+		printk(KERN_DEBUG "Device `[%s]' is not power manageable",
 				device->kobj.name);
 		return -ENODEV;
 	}

_