EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
PATCH 1/1 EXPORT_UNUSED_SYMBOL{,GPL} {,un}register_die_notifier
This patch marks {,un}register_die_notifier as
EXPORT_UNUSED_SYMBOL{,GPL}.
---
arch/i386/kernel/traps.c | 4 ++-- arch/ia64/kernel/traps.c | 4 ++-- arch/powerpc/kernel/traps.c | 4 ++-- arch/sparc64/kernel/traps.c | 4 ++-- arch/x86_64/kernel/traps.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +2 -2
@@ -101,13 +101,13 @@vmalloc_sync_all ();return atomic_notifier_chain_register (&i386die_chain, nb); } -EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ int unregister_die_notifier (struct notifier_block *nb) {return atomic_notifier_chain_unregister (&i386die_chain, nb); } -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ static inline int valid_stack_ptr (struct thread_info *tinfo,void *p) {
arch/ia64/kernel/traps.c renamed from arch/ia64/kernel/traps.c.old +2 -2
@@ -37,14 +37,14 @@ {return atomic_notifier_chain_register (&ia64die_chain, nb); } -EXPORT_SYMBOL_GPL (register_die_notifier); +EXPORT_UNUSED_SYMBOL_GPL (register_die_notifier);/* June 2006 */ int unregister_die_notifier (struct notifier_block *nb) {return atomic_notifier_chain_unregister (&ia64die_chain, nb); } -EXPORT_SYMBOL_GPL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL_GPL (unregister_die_notifier);/* June 2006 */ void __init trap_init (void )
arch/powerpc/kernel/traps.c renamed from arch/powerpc/kernel/traps.c.old +2 -2
@@ -85,13 +85,13 @@ {return atomic_notifier_chain_register (&powerpc_die_chain, nb); } -EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ int unregister_die_notifier (struct notifier_block *nb) {return atomic_notifier_chain_unregister (&powerpc_die_chain, nb); } -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ /* * Trap & Exception support
arch/sparc64/kernel/traps.c renamed from arch/sparc64/kernel/traps.c.old +2 -2
@@ -50,13 +50,13 @@ {return atomic_notifier_chain_register (&sparc64die_chain, nb); } -EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ int unregister_die_notifier (struct notifier_block *nb) {return atomic_notifier_chain_unregister (&sparc64die_chain, nb); } -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ /* When an irrecoverable trap occurs at tl > 0, the trap entry * code logs the trap state registers at every level in the trap
arch/x86_64/kernel/traps.c renamed from arch/x86_64/kernel/traps.c.old +2 -2
@@ -77,13 +77,13 @@vmalloc_sync_all ();return atomic_notifier_chain_register (&die_chain, nb); } -EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ int unregister_die_notifier (struct notifier_block *nb) {return atomic_notifier_chain_unregister (&die_chain, nb); } -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ static inline void conditional_sti (struct pt_regs *regs) {
arch/i386/kernel/traps.c line 110
Quoted 4 lines · On Fri, 30 Jun 2006 13:33:17 +0200 Adrian Bunk <[email protected]> wrote:
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +2
-2-EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */
I'd expect there are any number of low-level debugging quick-hacky modules around which want to hook into here.
We can try it I guess, but I expect we'll hear about it.
Ar Gwe, 2006-06-30 am 20:35 -0700, ysgrifennodd Andrew Morton:
Quoted 11 lines
arch/i386/kernel/traps.c line 110
Quoted 4 lines · On Fri, 30 Jun 2006 13:33:17 +0200 Adrian Bunk <[email protected]> wrote:
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +2
-2-EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ I'd expect there are any number of low-level debugging quick-hacky modules around which want to hook into here.
Quoted 1 line
We can try it I guess, but I expect we'll hear about it.
Some of the cluster modules use it too for fast failover.
Alan
Quoted 12 lines · Alan Cox
Ar Gwe, 2006-06-30 am 20:35 -0700, ysgrifennodd Andrew Morton:
Quoted 11 lines
arch/i386/kernel/traps.c line 110
Quoted 4 lines · On Fri, 30 Jun 2006 13:33:17 +0200 Adrian Bunk <[email protected]> wrote:
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +2
-2-EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ I'd expect there are any number of low-level debugging quick-hacky modules around which want to hook into here.
Quoted 3 lines
Quoted 1 line
We can try it I guess, but I expect we'll hear about it.
Some of the cluster modules use it too for fast failover.
which ones?
the gfs ones are in -mm and aren't using it...
Quoted 11 lines · Andrew Morton
arch/i386/kernel/traps.c line 110
Quoted 4 lines · On Fri, 30 Jun 2006 13:33:17 +0200 Adrian Bunk <[email protected]> wrote:
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +2
-2-EXPORT_SYMBOL (register_die_notifier); +EXPORT_UNUSED_SYMBOL (register_die_notifier);/* June 2006 */ -EXPORT_SYMBOL (unregister_die_notifier); +EXPORT_UNUSED_SYMBOL (unregister_die_notifier);/* June 2006 */ I'd expect there are any number of low-level debugging quick-hacky modules around which want to hook into here.
Quoted 1 line
We can try it I guess, but I expect we'll hear about it.
The XPC module, which is in the community tree, references both symbols. See arch/ia64/sn/kernel/xpc_main.c for details.
Dean
Quoted 2 lines · Adrian Bunk (on Fri, 30 Jun 2006 13:33:17 +0200) wrote:
This patch marks {,un}register_die_notifier as
EXPORT_UNUSED_SYMBOL{,GPL}.
KDB needs that.
Quoted 5 lines · Keith Owens
Quoted 2 lines · Adrian Bunk (on Fri, 30 Jun 2006 13:33:17 +0200) wrote:
This patch marks {,un}register_die_notifier as
EXPORT_UNUSED_SYMBOL{,GPL}.KDB needs that.
is kdb is strict module or does it need extra patches anyway?