Skip to contentSkip to conversation

libata: fix ehc->i.action setting in ata_eh_autopsy()

PATCH Applied Tejun Heo 2 participants 2 messages Jul 2, 2006 – Jul 6, 2006

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 libata: fix ehc->i.action setting in ata_eh_autopsy()

ata_eh_autopsy() used to directly assign determined action mask to ehc->i.action thus overriding actions set by some of nested analyze functions. This patch makes ata_eh_autopsy() add action masks just as it's done in other places.

---
Jeff, this doesn't cause too much trouble but it would be nice to have this fixed in #linus too. Thanks.

 drivers/scsi/libata-eh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

fda815b4e76189eda0fb6e9fab60fe191c9e019a

drivers/scsi/libata-eh.c +1 -1
index f2f29a8..4a670db 100644
@@ -1346,7 +1346,7 @@ static void ata_eh_autopsy(struct ata_po
 
 	/* record autopsy result */
 	ehc->i.dev = failed_dev;
-	ehc->i.action = action;
+	ehc->i.action |= action;
 
 	DPRINTK("EXIT\n");
 }
Signature · 1 line
1.3.2