fix stack overflow checking in modular non-SMP kernels
PATCH 1/1 fix stack overflow checking in modular non-SMP kernels
The sparc64 kernel's EXPORT_SYMBOL(_mcount) is inside an #ifdef CONFIG_SMP. This breaks modules in non-SMP kernels built with stack overflow checking (CONFIG_STACK_DEBUG=y), as modules_install reports:
WARNING: /lib/modules/2.6.17/kernel/drivers/ide/ide-cd.ko needs unknown symbol _mcount
Trivially fixed by moving EXPORT_SYMBOL(_mcount) outside of the #ifdef CONFIG_SMP.
arch/sparc64/kernel/sparc64_ksyms.c renamed from arch/sparc64/kernel/sparc64_ksyms.c.~1~ +5 -5
@@ -128,11 +128,6 @@ EXPORT_SYMBOL(__write_trylock);/* Hard IRQ locking */ EXPORT_SYMBOL (synchronize_irq); -#if defined(CONFIG_MCOUNT ) -extern void _mcount (void ); -EXPORT_SYMBOL (_mcount); -#endif -/* CPU online map and active count. */ EXPORT_SYMBOL (cpu_online_map);EXPORT_SYMBOL (phys_cpu_present_map);
@@ -140,6 +135,11 @@ EXPORT_SYMBOL(phys_cpu_present_map);EXPORT_SYMBOL (smp_call_function);#endif /* CONFIG_SMP */ +#if defined(CONFIG_MCOUNT ) +extern void _mcount (void ); +EXPORT_SYMBOL (_mcount); +#endif +EXPORT_SYMBOL (sparc64_get_clock_tick);/* semaphores */
David Miller
AppliedFrom: Mikael Pettersson <[email protected]>
Date: Tue, 4 Jul 2006 22:10:11 +0200 (MEST)
Quoted 11 lines
The sparc64 kernel's
EXPORT_SYMBOL(_mcount)is inside an #ifdefCONFIG_SMP. This breaks modules in non-SMP kernels built with stack overflow checking (CONFIG_STACK_DEBUG=y), asmodules_installreports:WARNING:
/lib/modules/2.6.17/kernel/drivers/ide/ide-cd.koneeds unknown symbol_mcountTrivially fixed by moving
EXPORT_SYMBOL(_mcount)outside of the #ifdefCONFIG_SMP.Signed-off-by Mikael Pettersson <[email protected]>
Applied, thanks Mikael.