Limit VIA and SIS AGP choices to x86
PATCH 1/1 Limit VIA and SIS AGP choices to x86
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
Index: ./drivers/char/agp/Kconfig
===================================================================
RCS file: /var/cvs/linux-2.6/drivers/char/agp/Kconfig,v retrieving revision 1.16
drivers/char/agp/Kconfig +2 -4
@@ -75,8 +75,6 @@ config AGP_INTEL E7205 and E7505 chipsets and full support for the 810, 815, 830M, 845G, 852GM, 855GM, 865G and I915 integrated graphics chipsets. - - config AGP_NVIDIA tristate "NVIDIA nForce/nForce2 chipset support" depends on AGP && X86_32
@@ -86,7 +84,7 @@ config AGP_NVIDIA config AGP_SIS tristate "SiS chipset support" - depends on AGP + depends on AGP && X86 help This option gives you AGP support for the GLX component of X on Silicon Integrated Systems [SiS] chipsets.
@@ -103,7 +101,7 @@ config AGP_SWORKS config AGP_VIA tristate "VIA chipset support" - depends on AGP + depends on AGP && X86 help This option gives you AGP support for the GLX component of X on VIA MVP3/Apollo Pro chipsets.
drivers/char/agp/Kconfig config AGP_NVIDIA · line 87
Quoted 9 lines · On Wed, 5 Jul 2006 11:57:25 -0600 Matthew Wilcox <[email protected]> wrote:
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
...
config
AGP_SISdrivers/char/agp/Kconfig +1
-1tristate "SiS chipset support" - depends on AGP + depends on AGP && X86
I never know what to do here.
Sure, the driver will not be used on that architecture. But there is some benefit in being able to cross-compile that driver on other architectures anyway. Sometimes it will pick up missed #includes, sometimes printk mismatches, various other assumptions which might be OK for x86 right now but which might cause problems in the future.
Need to balance a very minor con against some very minor pros ;)
Quoted 15 lines · Andrew Morton
drivers/char/agp/Kconfig config AGP_NVIDIA · line 87
Quoted 9 lines · On Wed, 5 Jul 2006 11:57:25 -0600 Matthew Wilcox <[email protected]> wrote:
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
...
config
AGP_SISdrivers/char/agp/Kconfig +1
-1tristate "SiS chipset support" - depends on AGP + depends on AGP && X86I never know what to do here.
Quoted 5 lines
Sure, the driver will not be used on that architecture. But there is some benefit in being able to cross-compile that driver on other architectures anyway. Sometimes it will pick up missed #includes, sometimes printk mismatches, various other assumptions which might be OK for x86 right now but which might cause problems in the future.
Should we have a NONNATIVE config option analogous to EXPERIMENTAL, so that it could be expressed as
depends on AGP && (X86 || NONNATIVE)
Seems to express the actual intentions.
Signature · 3 lines
Ben Pfaff email: [email protected] web: http://benpfaff.org
Quoted 10 lines · Ben Pfaff
Quoted 5 lines
Sure, the driver will not be used on that architecture. But there is some benefit in being able to cross-compile that driver on other architectures anyway. Sometimes it will pick up missed #includes, sometimes printk mismatches, various other assumptions which might be OK for x86 right now but which might cause problems in the future.
Should we have a NONNATIVE config option analogous to EXPERIMENTAL, so that it could be expressed as
depends on AGP && (X86 || NONNATIVE)Seems to express the actual intentions.
Gah, that would be awful. It'd end up riddled through kconfigs everywhere. It's also not really buying anything more than
(X86 || !X86) , at which point, they cancel each other out ;)
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 3 lines · Matthew Wilcox
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
VIA has turned up on PPC (some Apple notebooks).
SiS I'm not sure about.
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 6 lines · Dave Jones
Quoted 3 lines · Matthew Wilcox
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
VIA has turned up on PPC (some Apple notebooks).
only the southbridge... agp is a northbridge thing...
Quoted 9 lines · Arjan van de Ven
Quoted 6 lines · Dave Jones
Quoted 3 lines · Matthew Wilcox
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
VIA has turned up on PPC (some Apple notebooks).
only the southbridge... agp is a northbridge thing...
Maybe my memory is flaky, but I'm sure I recall a VIA northbridge in the ibook.
benh ?
Dave
Signature · 1 line
http://www.codemonkey.org.uk
Quoted 10 lines · Arjan van de Ven
Quoted 6 lines · Dave Jones
Quoted 3 lines · Matthew Wilcox
As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP chipsets available.
VIA has turned up on PPC (some Apple notebooks).
only the southbridge... agp is a northbridge thing...
Not necessarily. Some HyperTransport southbridges have AGP on them, for example.
-hpa
Quoted 7 lines · H. Peter Anvin
Quoted 6 lines · Arjan van de Ven
Quoted 5 lines · Dave Jones
Quoted 1 line · Matthew Wilcox
Quoted 1 line
As far as I am aware, Alpha, PPC and IA64 don't have VIA or
SIS AGP
Quoted 1 line
chipsets available.
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
VIA has turned up on PPC (some Apple notebooks).
only the southbridge... agp is a northbridge thing...
Not necessarily. Some HyperTransport southbridges have AGP on them, for example.
Yes, and this is evil because historically 90% people think about "xxxxxbridge" as "right bunch" of implemented electrical interfaces and not by MSR's or whatever else :)
Indrek