tg3: add amd8131 to "write reorder" chipsets

Add the AMD 8131 bridge to the list of chipsets that reorder writes.

---

 drivers/net/tg3.c |    2 ++
 1 files changed, 2 insertions(+)

index f645921..ce6f3be 100644
@@ -10078,6 +10078,8 @@ static int __devinit tg3_get_invariants(
 	static struct pci_device_id write_reorder_chipsets[] = {
 		{ PCI_DEVICE(PCI_VENDOR_ID_AMD,
 		             PCI_DEVICE_ID_AMD_FE_GATE_700C) },
+		{ PCI_DEVICE(PCI_VENDOR_ID_AMD,
+		             PCI_DEVICE_ID_AMD_8131_BRIDGE) },
 		{ PCI_DEVICE(PCI_VENDOR_ID_VIA,
 			     PCI_DEVICE_ID_VIA_8385_0) },
 		{ },

John W. Linville
[email protected]

From: "John W. Linville" <[email protected]>
Date: Fri, 7 Jul 2006 14:58:36 -0400

What failure report is this chipset blacklist addition based upon? I just want to look at the paper trail before adding this.

Thanks.

What? Due diligence? You must be joking!!! :-)

	https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174019#c48

Hth!

John

John W. Linville
[email protected]

Moreover, since e1000 suffers from reordering/write-combining problems on the 8132, I'm starting to see an (ugly) pattern here. I didn't know that tg3 has a whole blacklist for this, could this affect other network cards as well?

Auke

From: Auke Kok <[email protected]>
Date: Fri, 07 Jul 2006 13:21:38 -0700

The tg3 is probably more susceptible to this problem because of how it uses a software structure in memory for interrupt status and RX/TX descriptor table head/tail indexes.

Whereas the e1000 always has to synchronize with MMIO register reads to get interrupt status and the indexes.

From: "John W. Linville" <[email protected]>
Date: Fri, 7 Jul 2006 14:58:36 -0400

Applied, thanks John.